Skip to content

WEB-475: The data on the dispersion of savings accounts appears overlaping… #3546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EDSONZ-WASSWA wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

WEB-475: The data on the dispersion of savings accounts appears overlaping… #3546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/app/account-transfers/view-account-transfer/view-account-transfer.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,7 @@
.transfer-container {
display: flex;
flex-direction: column;
gap: 1.5rem;
position: relative;
padding-left: 20px;
width: 100%;
}
Comment on lines 9 to 13
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Restore positioning context for the status indicator

Line 16 makes .status-indicator absolutely positioned, but .transfer-container no longer defines a positioned ancestor. This can misalign the indicator bar relative to the transfer card.

Suggested fix 
 .transfer-container {
   display: flex;
   flex-direction: column;
+  position: relative;
   width: 100%;
 }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
.transfer-container {
display: flex;
flex-direction: column;
gap: 1.5rem;
position: relative;
padding-left: 20px;
width: 100%;
}
.transfer-container {
display: flex;
flex-direction: column;
position: relative;
width: 100%;
}
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In
`@src/app/account-transfers/view-account-transfer/view-account-transfer.component.scss`
around lines 9 - 13, The .status-indicator is absolutely positioned but its
ancestor .transfer-container is not positioned, so add a positioning context by
setting .transfer-container to position: relative (preserving its existing
display/flex rules) so the .status-indicator aligns correctly relative to the
transfer card; update the .transfer-container rule (the selector named
transfer-container) to include position: relative.


.status-indicator {
Expand All @@ -26,7 +24,8 @@
.transfer-section {
display: flex;
flex-direction: column;
gap: 0.75rem;
width: 100%;
position: relative;
}

.section-title {
Expand All @@ -42,6 +41,7 @@ mat-divider {
.info-grid {
display: grid;
gap: 0.75rem;
width: 100%;
}

.info-row {
Expand Down
Loading