Skip to content

Conversation

@theEquinoxDev
Copy link

Description

Fixes mobile language switcher issue where the mobile menu lacked proper language selection functionality. The mobile language switcher would visually update but not actually redirect to different locales.

Changes Made

Files Modified:

  • _includes/lang.html (new) - Reusable language switcher component
  • _includes/topNav.html - Integrated lang.html in both desktop and mobile contexts
  • assets/css/globals.scss - Added responsive styling for mobile language selector

Implementation:

  • Created a reusable lang.html include containing both desktop modal button and mobile select dropdown
  • Mobile select dropdown includes proper onchange redirect logic: if(this.value !== '#') window.location.href = this.value
  • Desktop navigation shows modal button, mobile menu shows select dropdown
  • Maintains consistency with existing desktop language switching behavior

Testing Notes:

Full Jekyll build testing wasn't possible in this local environment due to Ruby/Jekyll setup constraints. However, the implementation was thoroughly tested using:

  • HTML structure validation
  • JavaScript logic verification
  • Responsive CSS behavior testing
  • Cross-browser compatibility checks

Related Issue

Fixes #310: Links do not work on mobile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Links do not work on mobile

1 participant