Fix mobile language switcher issue #310 #318
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes mobile language switcher issue where the mobile menu lacked proper language selection functionality. The mobile language switcher would visually update but not actually redirect to different locales.
Changes Made
Files Modified:
_includes/lang.html(new) - Reusable language switcher component_includes/topNav.html- Integrated lang.html in both desktop and mobile contextsassets/css/globals.scss- Added responsive styling for mobile language selectorImplementation:
lang.htmlinclude containing both desktop modal button and mobile select dropdownonchangeredirect logic:if(this.value !== '#') window.location.href = this.valueTesting Notes:
Full Jekyll build testing wasn't possible in this local environment due to Ruby/Jekyll setup constraints. However, the implementation was thoroughly tested using:
Related Issue
Fixes #310: Links do not work on mobile