Skip to content

Fix mobile language switcher issue #310 #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theEquinoxDev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix mobile language switcher issue #310 #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions _includes/lang.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<!-- Language switcher - context determines which elements are shown -->
<!-- Desktop: Modal trigger button -->
<button class="languageSwitchButton" title="{{ locale.site_change_language }}" onclick="document.querySelector('.languageSwitcherDialog').showModal()">
<img src="/assets/img/monochrome/language.svg" alt="{{ locale.site_change_language_alt }}" />
</button>

<!-- Mobile: Select dropdown -->
<select class="languageSelect" onchange="if(this.value !== '#') window.location.href = this.value">
<option value="#">{{ locale.site_change_language }}</option>
{% for locale_item in site.localization.locales_set %}
<option value="/{% if locale_item[0] != 'en' %}{{ locale_item[0] }}/{% endif %}">{{ locale_item[1].name }}</option>
{% endfor %}
</select>

<!-- Include the modal dialog for desktop -->
{% include languageSwitcher.html %}
8 changes: 4 additions & 4 deletions _includes/topNav.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
{% include topNavImageLinks.html %}
<div class="textLinks">
{% include topNavTextLinks.html %}
<div class="mobileLanguageSwitcher">
{% include lang.html %}
</div>
</div>
</dialog>
<script>
Expand Down Expand Up @@ -40,10 +43,7 @@
{% include topNavTextLinks.html %}
</div>
<div>
{% include languageSwitcher.html %}
<button class="languageSwitchButton" title="{{ locale.site_change_language }}" onclick="document.querySelector('.languageSwitcherDialog').showModal()">
<img src="/assets/img/monochrome/language.svg" alt="{{ locale.site_change_language_alt }}" />
</button>
{% include lang.html %}
</div>
</div>
</div>
Expand Down
42 changes: 42 additions & 0 deletions assets/css/globals.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,48 @@ a {
@include linklikeButton;
}

// Desktop navigation language switcher
.languageSwitcherContainer {
.languageSelect {
display: none; // Hide select in desktop navigation
}
}

// Mobile language select in menu
.mobileLanguageSwitcher {
margin-top: 1rem;
padding: 1rem 0;
border-top: 1px solid color.adjust(colors.$background-light, $lightness: -10%);

@include colors.dark {
border-top-color: color.adjust(colors.$background-dark, $lightness: 10%);
}

.languageSwitchButton {
display: none; // Hide button in mobile menu
}

.languageSelect {
width: 100%;
padding: 0.75rem;
font-size: 1.1rem;
background: transparent;
color: inherit;
border: 1px solid color.adjust(colors.$background-light, $lightness: -20%);
border-radius: 4px;

@include colors.dark {
border-color: color.adjust(colors.$background-dark, $lightness: 20%);
background: color.adjust(colors.$background-dark, $lightness: 5%);
}

&:focus {
outline: 2px solid colors.$accent;
outline-offset: 2px;
}
}
}

.languageSwitcherDialog {
position: fixed;
top: 50%;
Expand Down