Fix: RPM Spec Processing Issues #1094
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamed-rekiba
changed the title
mohamed-rekiba
force-pushed
the
master
branch
from
51f10b4 to
ab76fa2
Compare
- Implement robust Lua scripting engine to enable sophisticated RPM spec file processing - Add comprehensive test suite covering Lua engine functionality and edge cases - Seamlessly integrate Lua engine with existing RPM macro expansion system - Enable shell command execution through %(command) syntax expansion - Prevent macro expansion in regular comments during RPM spec processing
This commit fixes two related issues with RPM spec parsing:
1. Option macro negation pattern recognition:
- Added support for negated option macros like %{-m:0} with negation
- Modified expandmacros() to properly detect negation patterns
- Sets correct mactest value for negation handling
2. RPM directive preservation in multi-line expansions:
- Fixed splitexpansionresult() escaping %if/%endif directives
- Added pattern matching to preserve RPM control directives
- Prevents breaking %if/%endif conditional logic
The fixes enable proper parsing of complex option macro expressions
within %if conditionals inside macro definitions.
Resolves: syntax error in expression parsing issues
Tests: All existing tests pass, enhanced test documentation
mohamed-rekiba
force-pushed
the
master
branch
from
ab76fa2 to
e490139
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce Lua Scripting Engine and Fix RPM Spec Processing Issues
Overview
This PR introduces a robust Lua scripting engine for advanced RPM spec file processing and resolves critical parsing issues with option macro negation and conditional directive preservation.
Resolves
Lua function causes syntax errors
Key Features
%(command)syntax expansionBug Fixes
%{-m:0}) by enhancing theexpandmacros()function to properly detect negation patterns and set correctmactestvalues%if/%endifdirectives being escaped in multi-line expansions by improvingsplitexpansionresult()pattern matching to preserve RPM control directivesTesting
Technical Details
The fixes specifically address syntax errors in expression parsing by enabling proper handling of complex option macro expressions within
%ifconditionals inside macro definitions.Resolves: Syntax error in expression parsing issues