Test: stabilize proposal confirmation feature spec - #3808
Open
RedZapdos123 wants to merge 3 commits into
Open
Conversation
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
RedZapdos123
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Issue #3807 reported that
spec/features/proposals_spec.rbcould fail intermittently when a participant confirms a proposal.This PR updates the proposal confirmation feature spec to avoid a stale Selenium node when the rails-ujs confirmation link redirects to the registration page.
It waits for the confirmation link to be present, triggers the click in the page context, and asserts the redirect with
have_current_path.Closes #3807.
Checklist:
ruby -c spec/features/proposals_spec.rb.git diff --check upstream/master...HEADlocally.Additional validation:
rspec ./spec/features/proposals_spec.rb:162 # Event as a participant confirms a proposalfailed withNode with given id does not belong to the document.