Use local rank for distributed Torch CUDA binding - #267
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
Use local rank for distributed Torch CUDA binding#267sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
This was referenced Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bind each distributed Torch worker to its node-local CUDA device instead of using the worker's global distributed rank as a device index.
init_distributed()currently usesRANKboth for process-group identity andtorch.cuda.set_device(). That works on a single node, but in a standard multi-nodetorchrunlaunch global ranks continue across nodes while CUDA device indices restart at zero on each host.Fixes #266.
Fix
RANKfordist.init_process_group();LOCAL_RANKfor CUDA device selection;RANKwhenLOCAL_RANKis absent, preserving existing single-node/custom-launch behavior;Regression coverage
Adds a CPU-only mocked regression with
RANK=5,LOCAL_RANK=1, andWORLD_SIZE=8verifying that:cuda:1;No tensor-parallel math, NCCL warmup behavior, or process-group configuration is otherwise changed.