Skip to content

Honor explicit eval sample counts and repeat selection - #293

Open
sylvesterkaczmarek wants to merge 15 commits into
openai:mainfrom
sylvesterkaczmarek:fix/healthbench-debug-examples
Open

Honor explicit eval sample counts and repeat selection#293
sylvesterkaczmarek wants to merge 15 commits into
openai:mainfrom
sylvesterkaczmarek:fix/healthbench-debug-examples

Conversation

@sylvesterkaczmarek

@sylvesterkaczmarek sylvesterkaczmarek commented Aug 16, 2026

Copy link
Copy Markdown

Summary

Make the eval CLI's documented --examples override apply consistently to sample counts, GPQA debug selection, and repeat counts.

Three CLI paths were inconsistent:

  • HealthBench debug runs hard-coded 10 examples even when the user supplied another positive count;
  • non-debug AIME and GPQA kept n_repeats=8 when an explicit subset was requested, which violates those constructors' n_repeats == 1 subset requirement;
  • GPQA debug mode always selected one fixed Espresso example and ignored an explicit positive sample count.

Fixes #292.
Fixes #298.
Fixes #299.

Fix

  • a positive explicit sample count wins over the eval-specific debug default;
  • --examples 0 means full/unlimited evaluation outside debug mode and uses the eval-specific debug default in debug mode;
  • HealthBench therefore retains its debug default of 10 when no count or zero is supplied;
  • positive explicit AIME/GPQA subsets use one repeat;
  • non-debug --examples 0 retains eight repeats;
  • debug AIME/GPQA runs use one repeat;
  • the fixed GPQA debug example is used only when no explicit sample count is supplied;
  • full non-debug AIME/GPQA evaluations retain eight repeats;
  • keep dependency-free resolution helpers in lightweight cli_utils.py.

Regression coverage

Adds lightweight tests for explicit, debug-default, full-run, and zero-example sample/repeat selection, plus GPQA fixed-debug versus explicit-subset selection.

Datasets, scoring, sampler configuration, and full-eval defaults are otherwise unchanged.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3f86f32943

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/gpt_oss/evals/test_cli_examples.py Outdated
@sylvesterkaczmarek sylvesterkaczmarek changed the title Honor explicit HealthBench sample counts in debug mode Honor explicit eval sample counts and repeat selection Aug 16, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7c02feaae8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread gpt_oss/evals/cli_utils.py Outdated
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e7fb5b0dd9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread gpt_oss/evals/__main__.py
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

Note

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@sylvesterkaczmarek

Copy link
Copy Markdown
Author

Addressed the remaining zero-example debug case: --examples 0 now maps to the eval-specific debug default in debug mode and to full/unlimited evaluation outside debug mode, with regression coverage for both paths. @codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Note

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant