Honor explicit eval sample counts and repeat selection - #293
Honor explicit eval sample counts and repeat selection#293sylvesterkaczmarek wants to merge 15 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f86f32943
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c02feaae8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e7fb5b0dd9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
|
Note You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Addressed the remaining zero-example debug case: |
|
Note You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary
Make the eval CLI's documented
--examplesoverride apply consistently to sample counts, GPQA debug selection, and repeat counts.Three CLI paths were inconsistent:
n_repeats=8when an explicit subset was requested, which violates those constructors'n_repeats == 1subset requirement;Fixes #292.
Fixes #298.
Fixes #299.
Fix
--examples 0means full/unlimited evaluation outside debug mode and uses the eval-specific debug default in debug mode;--examples 0retains eight repeats;cli_utils.py.Regression coverage
Adds lightweight tests for explicit, debug-default, full-run, and zero-example sample/repeat selection, plus GPQA fixed-debug versus explicit-subset selection.
Datasets, scoring, sampler configuration, and full-eval defaults are otherwise unchanged.