-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Honor explicit eval sample counts and repeat selection #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sylvesterkaczmarek
wants to merge
15
commits into
openai:main
Choose a base branch
from
sylvesterkaczmarek:fix/healthbench-debug-examples
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+77
−12
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b803c08
Honor explicit HealthBench debug sample counts
sylvesterkaczmarek 3f86f32
Add eval sample count regression tests
sylvesterkaczmarek c2e1341
Move eval sample-count helper to lightweight module
sylvesterkaczmarek 97118af
Use lightweight eval sample-count helper
sylvesterkaczmarek b1946d6
Keep CLI helper tests dependency-light
sylvesterkaczmarek 16883eb
Resolve eval repeat counts for explicit subsets
sylvesterkaczmarek a26c782
Use single repeat for explicit eval subsets
sylvesterkaczmarek 7c02fea
Cover eval repeat selection for explicit subsets
sylvesterkaczmarek 00f2857
Respect explicit GPQA subset selection
sylvesterkaczmarek 5ce32a1
Let explicit GPQA sample counts override fixed debug example
sylvesterkaczmarek c66f8ab
Cover explicit GPQA debug subset selection
sylvesterkaczmarek 93c23d1
fix: preserve full-run repeats for zero examples
sylvesterkaczmarek e7fb5b0
test: cover zero-example repeat selection
sylvesterkaczmarek 61ca8ee
fix: normalize zero-example CLI semantics
sylvesterkaczmarek 5a2c5af
test: cover zero-example debug defaults
sylvesterkaczmarek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| def resolve_num_examples( | ||
| explicit_examples: int | None, debug_mode: bool, debug_default: int | ||
| ) -> int | None: | ||
| if explicit_examples is not None: | ||
| if explicit_examples == 0: | ||
| return debug_default if debug_mode else None | ||
| return explicit_examples | ||
| return debug_default if debug_mode else None | ||
|
|
||
|
|
||
| def resolve_n_repeats(explicit_examples: int | None, debug_mode: bool) -> int: | ||
| explicit_subset = explicit_examples is not None and explicit_examples != 0 | ||
| return 1 if explicit_subset or debug_mode else 8 | ||
|
|
||
|
|
||
| def resolve_gpqa_debug_mode(explicit_examples: int | None, debug_mode: bool) -> bool: | ||
| return debug_mode and explicit_examples is None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| from gpt_oss.evals.cli_utils import ( | ||
| resolve_gpqa_debug_mode, | ||
| resolve_n_repeats, | ||
| resolve_num_examples, | ||
| ) | ||
|
|
||
|
|
||
| def test_explicit_examples_override_debug_default() -> None: | ||
| assert resolve_num_examples(2, debug_mode=True, debug_default=10) == 2 | ||
|
|
||
|
|
||
| def test_debug_default_is_used_without_explicit_examples() -> None: | ||
| assert resolve_num_examples(None, debug_mode=True, debug_default=10) == 10 | ||
|
|
||
|
|
||
| def test_full_eval_keeps_unlimited_examples() -> None: | ||
| assert resolve_num_examples(None, debug_mode=False, debug_default=10) is None | ||
|
|
||
|
|
||
| def test_zero_examples_keeps_full_run_outside_debug() -> None: | ||
| assert resolve_num_examples(0, debug_mode=False, debug_default=10) is None | ||
|
|
||
|
|
||
| def test_zero_examples_uses_debug_default_in_debug_mode() -> None: | ||
| assert resolve_num_examples(0, debug_mode=True, debug_default=10) == 10 | ||
|
|
||
|
|
||
| def test_explicit_subset_uses_single_repeat() -> None: | ||
| assert resolve_n_repeats(2, debug_mode=False) == 1 | ||
|
|
||
|
|
||
| def test_debug_run_uses_single_repeat() -> None: | ||
| assert resolve_n_repeats(None, debug_mode=True) == 1 | ||
|
|
||
|
|
||
| def test_full_run_keeps_eight_repeats() -> None: | ||
| assert resolve_n_repeats(None, debug_mode=False) == 8 | ||
|
|
||
|
|
||
| def test_zero_examples_keeps_full_run_repeats() -> None: | ||
| assert resolve_n_repeats(0, debug_mode=False) == 8 | ||
|
|
||
|
|
||
| def test_gpqa_fixed_debug_example_is_default_only() -> None: | ||
| assert resolve_gpqa_debug_mode(None, debug_mode=True) is True | ||
| assert resolve_gpqa_debug_mode(2, debug_mode=True) is False | ||
| assert resolve_gpqa_debug_mode(None, debug_mode=False) is False |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.