Skip to content

Finish remaining commands to support stacked images, add integration tests, benchmarking - #1307

Closed
yzhuang-oai wants to merge 1 commit into
mainfrom
support-diskimagekit-phase3
Closed

Finish remaining commands to support stacked images, add integration tests, benchmarking#1307
yzhuang-oai wants to merge 1 commit into
mainfrom
support-diskimagekit-phase3

Conversation

@yzhuang-oai

Copy link
Copy Markdown
Contributor

This is the last PR adding support for new
DiskImageKit ASIF layers to tart VM images.

https://developer.apple.com/documentation/diskimagekit

This change implements the remaining commands in tart
to support stacked disk image format as well as adding
integration test, benchmarking to ensure no performance
regressions.

Issue: #1269

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9c28baa854

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/tart/VMDirectory.swift Outdated
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3 branch from 9c28baa to 77e47a0 Compare August 7, 2026 19:28

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 77e47a09dc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/tart/VMStorageOCI.swift Outdated
Comment thread Sources/tart/VMDirectory+OCI.swift Outdated
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3 branch from 77e47a0 to e2f224a Compare August 7, 2026 20:22

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e2f224a5e9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/tart/VMStorageOCI.swift
Comment thread Sources/tart/VMDirectory+Archive.swift Outdated
Comment thread Sources/tart/VMStorageOCI.swift
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3 branch from e2f224a to d4b8d74 Compare August 7, 2026 20:50

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d4b8d74a72

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/tart/VMDirectory+Archive.swift
Comment thread Sources/tart/VMDirectory+Archive.swift Outdated
Comment thread Sources/tart/VMDirectory+DiskImageStack.swift
Comment thread Sources/tart/VMStorageOCI.swift
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3 branch from d4b8d74 to d23166c Compare August 7, 2026 21:49

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d23166c45d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/tart/VMStorageOCI.swift
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3 branch from d23166c to c92a920 Compare August 7, 2026 22:30

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c92a92066b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/tart/VMStorageOCI.swift
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3 branch from c92a920 to 12b101a Compare August 7, 2026 23:59

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 12b101ad0d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/tart/VMDirectory+Archive.swift Outdated
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3 branch from 12b101a to 379885b Compare August 8, 2026 01:21

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 379885b2b0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/tart/Commands/Prune.swift Outdated
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase2 branch from e33868e to d2ac6ac Compare August 10, 2026 16:19
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3 branch from 379885b to 095031b Compare August 10, 2026 16:19

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 095031b77e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/tart/VMDirectory+OCI.swift
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase2 branch from d2ac6ac to 27850da Compare August 10, 2026 17:40
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3 branch from 095031b to ac01873 Compare August 10, 2026 21:48

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ac01873869

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/tart/VMDirectory+Archive.swift Outdated
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase2 branch from 27850da to be44cc8 Compare August 11, 2026 16:32
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3 branch from ac01873 to 077422f Compare August 11, 2026 17:08

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 077422f4ce

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/tart/VMDirectory+Archive.swift Outdated
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3 branch from 077422f to 17308c9 Compare August 11, 2026 23:29
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase2 branch from b78f267 to 53ceac8 Compare August 12, 2026 02:14
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3 branch from 17308c9 to f2964f2 Compare August 12, 2026 02:16
@edi-oai edi-oai mentioned this pull request Aug 12, 2026
Base automatically changed from support-diskimagekit-phase2 to main August 12, 2026 19:10
An error occurred while trying to automatically change base from support-diskimagekit-phase2 to main August 12, 2026 19:10
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3 branch from f2964f2 to 3f4ddbd Compare August 12, 2026 20:33

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3f4ddbd023

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/tart/VMDirectory.swift Outdated
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3 branch from 3f4ddbd to 389e49a Compare August 12, 2026 20:43

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 389e49a90a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/tart/VMDirectory.swift Outdated
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3 branch 2 times, most recently from bc398b2 to fef568b Compare August 12, 2026 22:42

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fef568b562

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/tart/VMStorageOCI.swift Outdated
Finish implementing remaining tart commands to
support stacked disk image.

Add integration test and benchmarking.
@yzhuang-oai

Copy link
Copy Markdown
Contributor Author

Superseded by the smaller stacked PRs #1313, #1314, #1315, and #1316.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant