Skip to content

Add stacked disk integration coverage and documentation - #1316

Merged
yzhuang-oai merged 1 commit into
mainfrom
support-diskimagekit-phase3-tests-docs
Aug 18, 2026
Merged

Add stacked disk integration coverage and documentation#1316
yzhuang-oai merged 1 commit into
mainfrom
support-diskimagekit-phase3-tests-docs

Conversation

@yzhuang-oai

@yzhuang-oai yzhuang-oai commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Split from #1307. Adds the stacked OCI integration test, benchmark command, and user-facing documentation.

Stacked on #1315.

Validation: full Swift test suite passes locally; stacked OCI integration and benchmark were previously validated on a host running macOS 27 beta.

@yzhuang-oai
yzhuang-oai marked this pull request as ready for review August 17, 2026 16:09
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3-commands branch from 7704b65 to bb6e3d8 Compare August 17, 2026 16:30
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3-tests-docs branch from a9b4406 to 5b8a12d Compare August 17, 2026 16:30

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5b8a12dc8f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread benchmark/internal/command/stackedoci/stackedoci.go
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3-commands branch from bb6e3d8 to caaa331 Compare August 17, 2026 16:46
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3-tests-docs branch from 5b8a12d to 44aa22d Compare August 17, 2026 16:46

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 44aa22dc09

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread benchmark/internal/command/stackedoci/stackedoci.go
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3-commands branch from caaa331 to 50032eb Compare August 17, 2026 17:04
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3-tests-docs branch 2 times, most recently from 13ab515 to 28487e5 Compare August 17, 2026 17:40
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3-commands branch 2 times, most recently from 0f6b6bd to e6014c6 Compare August 17, 2026 20:07
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3-tests-docs branch from 28487e5 to ce4548c Compare August 17, 2026 20:07
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3-commands branch from e6014c6 to 93a4b29 Compare August 17, 2026 20:55
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3-tests-docs branch from ce4548c to 1ceb8e9 Compare August 17, 2026 20:55

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1ceb8e9250

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread integration-tests/test_stacked_oci.py
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3-commands branch from 93a4b29 to 52ef429 Compare August 17, 2026 21:24
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3-tests-docs branch from 1ceb8e9 to 4a36a01 Compare August 17, 2026 21:24
edi-oai
edi-oai previously approved these changes Aug 17, 2026

@edi-oai edi-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a couple of nits.

Comment thread docs/faq.md Outdated
Comment thread docs/quick-start.md Outdated
Base automatically changed from support-diskimagekit-phase3-commands to main August 17, 2026 22:20
@yzhuang-oai
yzhuang-oai dismissed edi-oai’s stale review August 17, 2026 22:20

The base branch was changed.

@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3-tests-docs branch from 4a36a01 to 9cae4b4 Compare August 17, 2026 22:25
@edi-oai
edi-oai self-requested a review August 17, 2026 23:22
edi-oai
edi-oai previously approved these changes Aug 17, 2026
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3-tests-docs branch from 9cae4b4 to d91b353 Compare August 17, 2026 23:37

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d91b3536c2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread integration-tests/test_stacked_oci.py Outdated
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3-tests-docs branch from d91b353 to 84c37ea Compare August 18, 2026 00:00
@yzhuang-oai
yzhuang-oai force-pushed the support-diskimagekit-phase3-tests-docs branch from 84c37ea to c9b9969 Compare August 18, 2026 00:16
@edi-oai
edi-oai self-requested a review August 18, 2026 09:10
@yzhuang-oai
yzhuang-oai merged commit 16d186c into main Aug 18, 2026
1 check passed
@yzhuang-oai
yzhuang-oai deleted the support-diskimagekit-phase3-tests-docs branch August 18, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants