enable cell_permute for coreneuron - #375
Merged
Merged
Conversation
cattabiani
force-pushed
the
katta/cell_permute
branch
from
September 3, 2025 12:54
9de04d1 to
c6f0b31
Compare
cattabiani
changed the base branch from
main
to
katta/compartment_sets_neurodamus
September 4, 2025 09:08
cattabiani
force-pushed
the
katta/cell_permute
branch
3 times, most recently
from
September 4, 2025 12:24
8aa73b3 to
c4cf7da
Compare
cattabiani
force-pushed
the
katta/cell_permute
branch
from
September 5, 2025 08:11
c4cf7da to
d432aae
Compare
… (gpu)}`. Neurodamus at the moment is not leveraging this. We should allow users to set this. **Note:** this is different from `cell-permute` for neuron (9+ only). I may enable that in the future. In that case this will become useless legacy code. At any rate, neuron 9 is new and not fully used everywhere. Proceeding step by step, enabling `cell-permute` in coreneuron is the next logical step * add option in CLI and in the python bindings * test that it is written in `sim.conf` * test that `integration-e2e/test_reports.py` is unaffected * add test in `test_reports.py`. I am using [this](neuronsimulator/nrn#3587) locally. It will fail in the CI until that one is merged
cattabiani
force-pushed
the
katta/cell_permute
branch
from
September 5, 2025 09:16
d432aae to
1bfeda3
Compare
cattabiani
marked this pull request as ready for review
September 5, 2025 09:16
1 task
mgeplf
reviewed
Sep 8, 2025
mgeplf
reviewed
Sep 9, 2025
WeinaJi
reviewed
Sep 9, 2025
WeinaJi
reviewed
Sep 11, 2025
WeinaJi
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
corenrncan run withcell-permute = {0 (cpu, gpu), 1 (cpu, gpu), 2 (gpu)}. Neurodamus at the moment is not leveraging this. We should allow users to set this.Note: this is different from
cell-permutefor neuron (9+ only). I may enable that in the future. In that case this will become useless legacy code. At any rate, neuron 9 is new and not fully used everywhere. Proceeding step by step, enablingcell-permutein coreneuron is the next logical stepScope
Testing
sim.confintegration-e2e/test_reports.pyis unaffected