Skip to content

Fix address form layout #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

priya-tik
Copy link

This PR refactors the address fields to improve clarity and organization. The changes aim to separate organizational and personal address information for better readability and maintainability.

If this is not what you were expecting, please let me know and I’ll be happy to make the necessary changes.
image

Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1294

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1294

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented May 19, 2025

This pull request is deployed at test.admin-interface.opencast.org/1294/2025-05-23_10-54-06/ .
It might take a few minutes for it to become available.

@gregorydlogan
Copy link
Member

Reorg looks good, and doesn't break anything. The branch history needs to be rebased though.

@Arnei Arnei added the type:visual-clarity Improves UI readability label May 21, 2025
@priya-tik priya-tik closed this May 21, 2025
@priya-tik priya-tik force-pushed the fix-address-form-layout branch from a28c115 to 458a674 Compare May 21, 2025 20:51
@priya-tik priya-tik reopened this May 21, 2025
@priya-tik
Copy link
Author

I accidentally closed this. Reopening to continue the discussion. Sorry for the noise

@priya-tik priya-tik force-pushed the fix-address-form-layout branch from a28c115 to 1dc775b Compare May 22, 2025 05:54
Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, code makes sense and if gregorydlogan says the layout makes sense like this then it's all good.

It seems some config files got mixed into your commit. Please remove those.

Small nitpicks below.

Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:visual-clarity Improves UI readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants