-
Notifications
You must be signed in to change notification settings - Fork 32
Fix address form layout #1294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix address form layout #1294
Conversation
Use Run test server using develop.opencast.org as backend:
Specify a different backend like stable.opencast.org:
It may take a few seconds for the interface to spin up. |
This pull request is deployed at test.admin-interface.opencast.org/1294/2025-05-23_10-54-06/ . |
Reorg looks good, and doesn't break anything. The branch history needs to be rebased though. |
a28c115
to
458a674
Compare
I accidentally closed this. Reopening to continue the discussion. Sorry for the noise |
a28c115
to
1dc775b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works, code makes sense and if gregorydlogan says the layout makes sense like this then it's all good.
It seems some config files got mixed into your commit. Please remove those.
Small nitpicks below.
This pull request has conflicts ☹ |
8b1fbe0
to
1dc775b
Compare
This PR refactors the address fields to improve clarity and organization. The changes aim to separate organizational and personal address information for better readability and maintainability.
If this is not what you were expecting, please let me know and I’ll be happy to make the necessary changes.
