-
-
Notifications
You must be signed in to change notification settings - Fork 25
Add Belgian solar PV forecast with integration test #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
peterdudfield
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this, this looks great. Ive added a few comments that I think are minor changes. Would you be able to look at them?
Thanks! I’ve pushed updates addressing all the comments — happy to tweak anything further if needed |
They looks really good. Would you just be able to update the Readme, and then we can get it merged? |
Done — I’ve updated the README. Happy to contribute to this issue. |
|
@peterdudfield, Could you let me know if there are any updates on this PR? |
|
Hey This looks really great thanks @Reem-Albadwy . I think this is ready to merge |
|
@peterdudfield, Glad to hear that! Thank you |
Pull Request
Description
This PR adds support for Belgian solar PV forecast data using the Elia Open Data API.
The changes include:
solar_consumer/data/fetch_be_data.pyThis follows the existing repository structure by keeping country-specific logic in the data module.
Fixes #127
How Has This Been Tested?
Ran the integration test locally:
pytest tests/integration/test_fetch_be_forecast.pyVerified the returned DataFrame contains the expected columns:
target_datetime_utcsolar_generation_kwregionforecast_typeConfirmed both national and at least one regional forecast are returned when data is available
Yes
Checklist: