Fix Docker build and enable git-based versioning #136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR fixes an issue where Docker builds always reported the application
version as
0.0.0, even when git tags were present.What changed
setuptools-git-versioningtobuild-system.requiresso the pluginis available at build time.
relying on git at runtime.
Why
Without
setuptools-git-versioninginstalled at build time, setuptoolssilently fell back to
0.0.0. This caused incorrect version logging inproduction Docker images.
With this change, Docker images correctly reflect the git tag version
(e.g.
1.4.14) in logs.Fixes #126
How Has This Been Tested?
Built the Docker image locally using
docker build --no-cache.Ran the container and verified the startup logs report the correct version.
Verified runtime version directly using:
python -c "from solar_consumer import __version__; print(__version__)"Yes
Checklist: