feat(search): video facet - #3201
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 1 |
🟢 Coverage 40.30% diff coverage · +0.04% coverage variation
Metric Results Coverage variation ✅ +0.04% coverage variation (-1.00%) Diff coverage ✅ 40.30% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (f60e2e5) 87708 20427 23.29% Head commit (727c986) 87901 (+193) 20510 (+83) 23.33% (+0.04%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#3201) 201 81 40.30% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
dschmidt
force-pushed
the
feat/search-video-facet
branch
2 times, most recently
from
July 30, 2026 11:41
5aa11c6 to
22f66de
Compare
dschmidt
force-pushed
the
feat/search-tika-facets
branch
from
August 18, 2026 16:28
c7c0551 to
35231b1
Compare
dschmidt
force-pushed
the
feat/search-video-facet
branch
from
August 18, 2026 16:32
22f66de to
37d863b
Compare
dschmidt
force-pushed
the
feat/search-tika-facets
branch
3 times, most recently
from
August 31, 2026 17:00
19fb88d to
a9c7079
Compare
dschmidt
force-pushed
the
feat/search-video-facet
branch
4 times, most recently
from
August 31, 2026 18:19
7ce4dbe to
3a1754a
Compare
dschmidt
marked this pull request as ready for review
August 31, 2026 18:19
dschmidt
force-pushed
the
feat/search-video-facet
branch
3 times, most recently
from
August 31, 2026 18:37
2954f71 to
db5b3f4
Compare
fschade
force-pushed
the
feat/search-tika-facets
branch
from
September 1, 2026 05:17
2329c62 to
240239d
Compare
dschmidt
force-pushed
the
feat/search-video-facet
branch
from
September 1, 2026 05:48
db5b3f4 to
027b8ac
Compare
dschmidt
force-pushed
the
feat/search-tika-facets
branch
from
September 1, 2026 07:10
240239d to
5e4f124
Compare
dschmidt
force-pushed
the
feat/search-video-facet
branch
from
September 1, 2026 07:11
027b8ac to
76d98d9
Compare
dschmidt
force-pushed
the
feat/search-video-facet
branch
2 times, most recently
from
September 1, 2026 13:30
b46290c to
b473b6a
Compare
dschmidt
force-pushed
the
feat/search-video-facet
branch
from
September 1, 2026 14:27
b473b6a to
727c986
Compare
butonic
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3198 (tika facets).
Adds the video facet (dimensions, duration, codec, audio stream details) to the search index, the search API and the graph driveItem.
Maps what the released Tika 4.0.0 exposes for MP4/MOV:
width,height,duration,bitrate(video:bitrate, TIKA-4802),frameRate(video:frame-rate, TIKA-4800),audioSamplesPerSecond,audioBitsPerSample(audio:bits-per-sample),audioChannels(numeric audio:channels, enum fallback). Verified against a liveapache/tika:4.0.0-fullwith a generated MP4; against a Tika that does not emit these keys the facet simply stays empty.Tika stores the video track dimensions under the same
tiff:ImageWidth/tiff:ImageLengthkeys it uses for images (viaMetadata.IMAGE_WIDTH), so image and video would otherwise both match.getImageis now gated on theimage/content type andgetVideoonvideo/, inside the respective facet function, so a file gets exactly one of the two.Still open: the codec FourCCs.
video:fourcc(fourCC) andaudio:fourcc(audioFormat) land with Tika 4.1 (TIKA-4838) and are already wired up here; until then both stay empty. ThexmpDM:videoCompressorname ("AVC Coding") is no FourCC, so it is deliberately not used as a stand-in.Needs a separate reva change, not includable here (same as #3200): the WebDAV PROPFIND handler must know the
videokeys to expose the facet over WebDAV. It lives in vendored reva, so it needs its own reva PR + dependency bump. The required diff: