feat(ocdav): expose the video, motionPhoto and livePhoto facets - #790
feat(ocdav): expose the video, motionPhoto and livePhoto facets#790dschmidt wants to merge 2 commits into
Conversation
|
Personally, I would not add features to webdav. Otherwise, if clients want these properties the incentive to move to graph is gone. I would actually strip down webdav to a point where it no longer carries opencloud specific properties and just exists as a legacy mechanism for file access. Wishful thinking ... I know ... |
|
You know I'm pushing the graph api very hard so we can switch web over asap - independent of the new facets. It would still make me very happy if I could work on the motion photos feature in the web ui in parallel anyway. Once we switched over I'm happy to get rid of these facets again |
|
https://ci.opencloud.rocks/repos/4/pipeline/586/19 hmmm flaky? not yet initialized 🤔 |
|
Not our test — the spec races with itself. |
PROPFIND can only render a facet whose keys it knows. Adds the three the graph API already has:
oc:videooc:motion-photooc:live-photoWired like
audio/location/image/photo, keys taken from the libregraph models.Counterpart to opencloud-eu/opencloud#3201, cs3org#3200 and cs3org#3202. Graph-only facets (lockInfo, shareTypes, allowedValues) stay out.