feat(search): live photo facet - #3202
Open
dschmidt wants to merge 4 commits into
Open
Conversation
dschmidt
force-pushed
the
feat/search-live-photo-facet
branch
from
July 29, 2026 23:47
75dff44 to
bacb762
Compare
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 18 |
| Duplication | 0 |
🟢 Coverage 27.35% diff coverage · -0.01% coverage variation
Metric Results Coverage variation ✅ -0.01% coverage variation (-1.00%) Diff coverage ✅ 27.35% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (e6102c0) 88120 20619 23.40% Head commit (5995938) 88220 (+100) 20637 (+18) 23.39% (-0.01%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#3202) 117 32 27.35% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
dschmidt
force-pushed
the
feat/search-live-photo-facet
branch
2 times, most recently
from
July 30, 2026 11:39
4cf6a80 to
ceb63a5
Compare
dschmidt
force-pushed
the
feat/search-live-photo-facet
branch
from
August 18, 2026 16:33
ceb63a5 to
bebf05c
Compare
dschmidt
force-pushed
the
feat/search-live-photo-facet
branch
from
August 31, 2026 15:21
bebf05c to
81b1f77
Compare
dschmidt
force-pushed
the
feat/search-live-photo-facet
branch
from
August 31, 2026 17:01
81b1f77 to
0368eb5
Compare
dschmidt
force-pushed
the
feat/search-live-photo-facet
branch
from
August 31, 2026 17:53
0368eb5 to
39ec929
Compare
dschmidt
force-pushed
the
feat/search-live-photo-facet
branch
from
August 31, 2026 17:55
39ec929 to
293db4d
Compare
dschmidt
force-pushed
the
feat/search-live-photo-facet
branch
from
August 31, 2026 18:06
293db4d to
8981d20
Compare
dschmidt
marked this pull request as ready for review
August 31, 2026 18:07
dschmidt
force-pushed
the
feat/search-live-photo-facet
branch
from
August 31, 2026 18:37
8981d20 to
a8d73df
Compare
fschade
force-pushed
the
feat/search-live-photo-facet
branch
from
September 1, 2026 05:17
a8d73df to
8488740
Compare
dschmidt
force-pushed
the
feat/search-live-photo-facet
branch
from
September 1, 2026 07:14
8488740 to
f09f1f8
Compare
dschmidt
force-pushed
the
feat/search-live-photo-facet
branch
from
September 1, 2026 11:12
f09f1f8 to
4cfc14e
Compare
dschmidt
force-pushed
the
feat/search-live-photo-facet
branch
from
September 1, 2026 13:30
4cfc14e to
1a9e825
Compare
dschmidt
force-pushed
the
feat/search-live-photo-facet
branch
2 times, most recently
from
September 2, 2026 21:07
0db2399 to
2f1ca63
Compare
butonic
force-pushed
the
feat/search-live-photo-facet
branch
from
September 2, 2026 22:15
2f1ca63 to
8204688
Compare
butonic
reviewed
Sep 2, 2026
dschmidt
force-pushed
the
feat/search-live-photo-facet
branch
from
September 2, 2026 23:14
8204688 to
ad53ebe
Compare
dschmidt
force-pushed
the
feat/search-live-photo-facet
branch
from
September 3, 2026 01:34
25c78d1 to
5995938
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3200 (motion photo).
Adds the Apple Live Photo facet to the search index, the search API and the graph driveItem.
An Apple Live Photo is a pair of files (a still + a separate
.mov) linked by a shared content identifier. MapscontentId(fromcom.apple.quicktime.content.identifieron the video, or the Apple maker noteContent Identifieron the still),stillImageTimeUs,auto,vitalityScoreandvitalityScoringVersion. Without a pairing id (missing or empty) the facet is dropped entirely, andcontentIdis indexed as an opaque id, no case-insensitive or word-broken search siblings. Requires Tika 4 on both halves: the HEIC maker note is parsed since metadata-extractor 2.21.0, Tika 3 emits none of the keys, so the facet simply stays empty there. Verified against the pinned Tika 4.0 snapshot with a real.mov(com.apple.quicktime.live-photo.*atoms are surfaced generically); the still half is not yet verified against a real HEIC.Needs a separate reva change (same as #3200): the WebDAV PROPFIND handler must know the
livePhotokeys. It lives in vendored reva, so it needs its own reva PR + bump: