Skip to content

feat(ocdav): expose the video, motionPhoto and livePhoto facets #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dschmidt merged 2 commits into from
Sep 3, 2026
+46 −1
Merged

feat(ocdav): expose the video, motionPhoto and livePhoto facets #790

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3c417d
feat(ocdav): expose the video, motionPhoto and livePhoto facets
dschmidt Sep 3, 2026
d289ac1
refactor(ocdav): name the new props kebab-case like the rest
dschmidt Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 46 additions & 1 deletion internal/http/services/owncloud/ocdav/propfind/propfind.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,30 @@ var (
"width",
"height",
}
videoKeys = []string{
"audioBitsPerSample",
"audioChannels",
"audioFormat",
"audioSamplesPerSecond",
"bitrate",
"duration",
"fourCC",
"frameRate",
"height",
"width",
}
motionPhotoKeys = []string{
"presentationTimestampUs",
"version",
"videoSize",
}
livePhotoKeys = []string{
"auto",
"contentId",
"stillImageTimeUs",
"vitalityScore",
"vitalityScoringVersion",
}
photoKeys = []string{
"cameraMake",
"cameraModel",
Expand Down Expand Up @@ -887,6 +911,12 @@ func metadataKeys(pf XML) ([]string, []string) {
metadataKeys = append(metadataKeys, metadataKeysWithPrefix("libre.graph.image", imageKeys)...)
case "http://owncloud.org/ns/photo":
metadataKeys = append(metadataKeys, metadataKeysWithPrefix("libre.graph.photo", photoKeys)...)
case "http://owncloud.org/ns/video":
metadataKeys = append(metadataKeys, metadataKeysWithPrefix("libre.graph.video", videoKeys)...)
case "http://owncloud.org/ns/motion-photo":
metadataKeys = append(metadataKeys, metadataKeysWithPrefix("libre.graph.motionPhoto", motionPhotoKeys)...)
case "http://owncloud.org/ns/live-photo":
metadataKeys = append(metadataKeys, metadataKeysWithPrefix("libre.graph.livePhoto", livePhotoKeys)...)
default:
metadataKeys = append(metadataKeys, key)
}
Expand Down Expand Up @@ -944,7 +974,7 @@ func requiresExplicitFetching(n *xml.Name) bool {
}
case net.NsOwncloud:
switch n.Local {
case "favorite", "share-types", "checksums", "size", "tags", "audio", "location", "image", "photo":
case "favorite", "share-types", "checksums", "size", "tags", "audio", "location", "image", "photo", "video", "motion-photo", "live-photo":
return true
default:
return false
Expand Down Expand Up @@ -1292,6 +1322,9 @@ func mdToPropResponse(ctx context.Context, pf *XML, md *provider.ResourceInfo, p
appendMetadataProp(k, "oc", "location", "libre.graph.location", locationKeys)
appendMetadataProp(k, "oc", "image", "libre.graph.image", imageKeys)
appendMetadataProp(k, "oc", "photo", "libre.graph.photo", photoKeys)
appendMetadataProp(k, "oc", "video", "libre.graph.video", videoKeys)
appendMetadataProp(k, "oc", "motion-photo", "libre.graph.motionPhoto", motionPhotoKeys)
appendMetadataProp(k, "oc", "live-photo", "libre.graph.livePhoto", livePhotoKeys)
}

if md.Type == provider.ResourceType_RESOURCE_TYPE_CONTAINER {
Expand Down Expand Up @@ -1579,6 +1612,18 @@ func mdToPropResponse(ctx context.Context, pf *XML, md *provider.ResourceInfo, p
if k := md.GetArbitraryMetadata().GetMetadata(); k != nil {
appendMetadataProp(k, "oc", "photo", "libre.graph.photo", photoKeys)
}
case "video":
if k := md.GetArbitraryMetadata().GetMetadata(); k != nil {
appendMetadataProp(k, "oc", "video", "libre.graph.video", videoKeys)
}
case "motion-photo":
if k := md.GetArbitraryMetadata().GetMetadata(); k != nil {
appendMetadataProp(k, "oc", "motion-photo", "libre.graph.motionPhoto", motionPhotoKeys)
}
case "live-photo":
if k := md.GetArbitraryMetadata().GetMetadata(); k != nil {
appendMetadataProp(k, "oc", "live-photo", "libre.graph.livePhoto", livePhotoKeys)
}
case "name":
appendToOK(prop.Escaped("oc:name", md.Name))
case "shareid":
Expand Down