fix(jsoncs3): wait for init before asserting the migration timeout - #792
Open
dschmidt wants to merge 1 commit into
Open
fix(jsoncs3): wait for init before asserting the migration timeout#792dschmidt wants to merge 1 commit into
dschmidt wants to merge 1 commit into
Conversation
New() initializes the metadata storage in a background goroutine. The CleanupStaleShares spec started its 1ms context right after New(), so under load the context expired during initialization and the manager returned "not yet initialized" instead of the migration timeout. Expose Ready() and wait for it before starting the timeout context.
dschmidt
force-pushed
the
fix/jsoncs3-cleanup-stale-shares-test-race
branch
from
September 3, 2026 12:20
4a6ed98 to
ccdac30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New()initializes the metadata storage in a background goroutine. TheCleanupStaleSharesspec started its 1ms context right afterNew(), soCleanupStaleSharesraced:On a loaded machine the context expires before
Init+MakeDirIfNotExist+MarkAllAppliedare done, so the first wait returns and the spec fails:Reproduced with 8 busy loops on 4 cores: 21 of 40 runs failed.
This exposes
Ready()and waits for it before starting the timeout context. The timeout then only applies to the migration wait, which is what the spec asserts. Same load, 0 of 40 runs failed; package is green under-race.Seen on https://ci.opencloud.rocks/repos/4/pipeline/586/19, unrelated to the PR it failed on (#790).