fix(web-pkg): embed pasted images in rich text editors - #3527
Merged
Merged
Conversation
JammingBen
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Copying an image (e.g. from the preview app) and pasting it into a note (
.ocnote) or markdown file didn't work.The image file handler of the rich text editors only handled dropped files, so the pasted image file was ignored. ProseMirror then fell back to the
text/htmlclipboard payload, which is<img src="blob:...">. The preview app renders images via object urls, so the inserted image pointed to a blob url that is only valid in the page that created it and breaks after a reload.The image file handler now also handles pasted image files: they get embedded as data url at the cursor position, the same way dropped images are. The paste event is consumed so the blob image from the html payload isn't inserted on top of it. Only known image mime types are handled, so pasting other copied files keeps the default behavior.
Related Issue
How Has This Been Tested?
.ocnotefile → image is embedded and survives a reload.mdfile → image is embedded as data urlTypes of changes