Skip to content

README for gnmi-3.6 union_replace#5035

Merged
dplore merged 14 commits intomainfrom
dplore/union_replace_warn
Apr 3, 2026
Merged

README for gnmi-3.6 union_replace#5035
dplore merged 14 commits intomainfrom
dplore/union_replace_warn

Conversation

@dplore
Copy link
Copy Markdown
Member

@dplore dplore commented Jan 30, 2026 •
edited
Loading

The first of a list of tests which excercise gNMI union_replace with positive and negative test cases for mixing OC and CLI.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Jan 30, 2026

Summary of Changes

Hello @dplore, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive documentation for a new set of tests designed to validate the gNMI-3 union_replace specification. The primary goal of these tests is to ensure that network devices correctly process and apply configuration changes, even when they involve potential mismatches with underlying hardware, and to verify that such operations are accepted with appropriate warnings. The added README provides a clear guide for understanding and executing these critical validation steps.

Highlights

  • New Test Documentation: A new README file has been added to document tests for the gNMI-3: union_replace specification.
  • Union Replace Validation: The documented tests focus on validating the union_replace behavior, particularly how devices handle interface configurations with hardware mismatches (e.g., port-speed) and accept them with warnings.
  • Test Procedures and Examples: The README outlines detailed test procedures, including environment setup, specific steps for gNMI-3.6 scenarios, a canonical OpenConfig JSON example, and a list of covered OpenConfig paths and gNMI RPCs (gNMI.Set, gNMI.Get, gNMI.Subscribe).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented Jan 30, 2026 •
edited
Loading

Pull Request Functional Test Report for #5035 / 35e57a8

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
 gNMI-3: union_replace
 082c9000 Log
Cisco 8000E status
 gNMI-3: union_replace
 27fde8c7 Log
Cisco XRd status
 gNMI-3: union_replace
 820a072c Log
Juniper ncPTX status
 gNMI-3: union_replace
 c7adb1c5 Log
Nokia SR Linux status
 gNMI-3: union_replace
 86c18d74 Log
Openconfig Lemming status
 gNMI-3: union_replace
 dc0eb4b3 Log

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
 gNMI-3: union_replace
Cisco 8808 status
 gNMI-3: union_replace
Juniper PTX10008 status
 gNMI-3: union_replace
Nokia 7250 IXR-10e status
 gNMI-3: union_replace

Help

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a README for the gnmi-3 union_replace test. The README is a good start, but it has some structural issues and is missing a required section when compared to the test plan template. I've provided suggestions to align it with the template and improve clarity.

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 30, 2026 •
edited
Loading

Pull Request Test Coverage Report for Build 21883096965

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 10.114%
Totals Coverage Status
Change from base Build 21865339817: 0.0%
Covered Lines: 2300
Relevant Lines: 22741
💛 - Coveralls

@dplore dplore marked this pull request as ready for review February 4, 2026 22:57
@dplore dplore requested a review from a team as a code owner February 4, 2026 22:57
@dplore dplore linked an issue Mar 4, 2026 that may be closed by this pull request
gnmi-3.1 union_replace origin README and test Code #5015
Closed
gprateekjn
gprateekjn reviewed Mar 5, 2026
View reviewed changes
gprateekjn
gprateekjn reviewed Mar 5, 2026
View reviewed changes
@dplore dplore merged commit e1852e2 into main Apr 3, 2026
17 of 18 checks passed
@dplore dplore deleted the dplore/union_replace_warn branch April 3, 2026 19:07
@dplore dplore changed the title README for gnmi-3 union_replace README for gnmi-3.6 union_replace Apr 3, 2026
nsadhasivam pushed a commit to nsadhasivam/featureprofiles that referenced this pull request Apr 6, 2026
@dplore @nsadhasivam
README for gnmi-3 union_replace (openconfig#5035)
47052ca 
* README for gnmi-3 union_replace

* formatting

* testbed

* generate addrundata

* Update port names and speeds in README.md

* Enable union_replace in gNMI.Set RPC

* Fix typo in README.md for union_replace_test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gprateekjn gprateekjn gprateekjn approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@gprateekjn gprateekjn

Labels

None yet

Projects

Feature Profiles Test Development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

gnmi-3.1 union_replace origin README and test Code

4 participants

@dplore @OpenConfigBot @coveralls @gprateekjn