-
Notifications
You must be signed in to change notification settings - Fork 208
README for gnmi-3.6 union_replace #5035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
886d536
README for gnmi-3 union_replace
dplore 3e69efc
Merge branch 'main' into dplore/union_replace_warn
dplore 10e6c6e
formatting
dplore 82e936e
testbed
dplore cc71c6e
generate addrundata
dplore 1d902f2
Update port names and speeds in README.md
dplore a6708b6
Merge branch 'main' into dplore/union_replace_warn
dplore e2b5b7f
Merge branch 'main' into dplore/union_replace_warn
dplore 8b0fc0d
Merge branch 'main' into dplore/union_replace_warn
dplore 1f51517
Merge branch 'main' into dplore/union_replace_warn
dplore 63a3a20
Enable union_replace in gNMI.Set RPC
dplore c24f897
Fix typo in README.md for union_replace_test
dplore f02cf71
Merge branch 'main' into dplore/union_replace_warn
dplore 35e57a8
Merge branch 'main' into dplore/union_replace_warn
dplore File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| # gNMI-3: union_replace | ||
|
|
||
| ## Summary | ||
|
|
||
| Perform a series of tests that validate the union_replace specification. | ||
|
|
||
| In depth tests for use of union_replace should reside within the features being | ||
| tested. | ||
|
|
||
| ## Testbed type | ||
|
|
||
| * [Single DUT testbed](https://github.com/openconfig/featureprofiles/blob/main/topologies/dut.testbed) | ||
|
|
||
| ## Procedure | ||
|
|
||
| ### Test environment setup | ||
|
|
||
| * Get the DUT configuriation in CLI format and store as `baseline_cfg`. | ||
|
|
||
| ### gNMI-3.6 - union_replace accepted with warning | ||
|
|
||
| Interface configurations containing a mismatch with hardware (for example, due | ||
| to a missing or incompatible transceiver module) must be accepted by a device. | ||
| The interface with a configuration which doesn't match the hardware is expected | ||
| to be in a down operational state as the result of such a configuration commit. | ||
|
|
||
| Generic test steps | ||
|
|
||
| * Generate a configuration baseline_cfg + D.1 where D1 contains a port-speed in | ||
| which does not match the DUT hardware. | ||
| * Push the configuration to the DUT | ||
| * Verify the gnmi.Set is accepted | ||
| * Get configuration D.2 | ||
| * Verify D.1 == D.2. That is, verify only the interface speed is changed | ||
| between baseline_cfg and D.2. The remaining CLI and all OC must be unchanged. | ||
|
|
||
| #### gnmi3.6.1 verify configuration with OC with warning is accepted | ||
|
|
||
| Perform the steps where the with a port-speed mismatch is in OC. | ||
|
|
||
| #### gnmi3.6.2 verify configuration with CLI with warning is accepted | ||
|
|
||
| Perform the steps where the with a port-speed mismatch is in CLI. | ||
|
|
||
| ## Canonical OC | ||
|
|
||
| ```json | ||
| { | ||
| "components": { | ||
| "component": [ | ||
| { | ||
| "config": { | ||
| "name": "Port0" | ||
| }, | ||
| "name": "Port0", | ||
| "port": { | ||
| "breakout-mode": { | ||
| "groups": { | ||
| "group": [ | ||
| { | ||
| "config": { | ||
| "breakout-speed": "SPEED_50GB", | ||
| "index": 1, | ||
| "num-breakouts": 2, | ||
| "num-physical-channels": 2 | ||
| }, | ||
| "index": 1 | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "config": { | ||
| "name": "Port0-Transceiver" | ||
| }, | ||
| "name": "Port0-Transceiver", | ||
| "state": { | ||
| "parent": "Port0", | ||
| "type": "TRANSCEIVER" | ||
| }, | ||
| "transceiver": { | ||
| "state": { | ||
| "form-factor": "QSFP28" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "interfaces": { | ||
| "interface": [ | ||
| { | ||
| "config": { | ||
| "description": "First 50G breakout", | ||
| "name": "eth0/0" | ||
| }, | ||
| "ethernet": { | ||
| "config": { | ||
| "port-speed": "SPEED_50GB" | ||
| } | ||
| }, | ||
| "name": "eth0/0" | ||
| }, | ||
| { | ||
| "config": { | ||
| "description": "Second 50G breakout with wrong port-speed", | ||
| "name": "eth0/1" | ||
| }, | ||
| "ethernet": { | ||
| "config": { | ||
| "port-speed": "SPEED_100GB" | ||
| } | ||
| }, | ||
| "name": "eth0/1" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ## OpenConfig Path and RPC Coverage | ||
|
|
||
| ```yaml | ||
| paths: | ||
| /interfaces/interface/ethernet/config/port-speed: | ||
| /interfaces/interface/ethernet/state/port-speed: | ||
|
|
||
| rpcs: | ||
| gnmi: | ||
| gNMI.Set: | ||
| union_replace: true | ||
| gNMI.Get: | ||
| gNMI.Subscribe: | ||
| ``` | ||
|
|
||
| ## Required DUT platform | ||
|
|
||
| vRX | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # proto-file: github.com/openconfig/featureprofiles/proto/metadata.proto | ||
| # proto-message: Metadata | ||
|
|
||
| uuid: "ac092ed2-0383-4eeb-b7ed-624b0c7f8477" | ||
| plan_id: "gNMI-3" | ||
| description: "union_replace" | ||
| testbed: TESTBED_DUT_ATE_2LINKS |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.