bmp-1.1 bmp_base_session_test.go

[cprabha]

Hi,

1. Adding vendor specific cli commands to enable bmp.
2. Also network instance type is set to default as in other tests.
3. some of the cli set request is not under vendor specific, moved the code under vendor specific tag.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the BGP Monitoring Protocol (BMP) test suite by introducing vendor-specific configurations, particularly for Juniper devices. It refactors existing BGP configuration logic to support platform-specific CLI commands for features like maximum routes and multipath, and ensures consistent default network instance settings in tests. The changes aim to improve the robustness and compatibility of BGP and BMP configurations across different network device vendors.

Highlights

• Vendor-Specific BMP Configuration: Added vendor-specific CLI commands to enable BMP (BGP Monitoring Protocol) for Juniper devices, allowing for detailed route monitoring configurations.
• Default Network Instance Configuration: Ensured that the network instance type is consistently set to default in relevant tests, aligning with existing test patterns.
• BGP Configuration Refactoring: Moved certain BGP CLI set requests, previously generic, under a vendor-specific tag to improve modularity and platform-specific handling.

Changelog

• feature/bgp/bmp/otg_tests/bmp_base_session_test/bmp_base_session_test.go
  • Configured the default network instance for the DUT.
• feature/bgp/bmp/otg_tests/bmp_base_session_test/metadata.textproto
  • Added Juniper-specific platform exception for BMP OpenConfig unsupport.
• internal/cfgplugins/bgp.go
  • Refactored BGP maximum routes and multipath configuration to be vendor-specific.
  • Implemented Juniper-specific CLI commands for BMP configuration, including pre-policy and post-policy route monitoring.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5202 / af2cf8e

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		BMP-1.1: BMP Session Establishment and Telemetry Test
Cisco 8000E		BMP-1.1: BMP Session Establishment and Telemetry Test
Cisco XRd		BMP-1.1: BMP Session Establishment and Telemetry Test
Juniper ncPTX		BMP-1.1: BMP Session Establishment and Telemetry Test
Nokia SR Linux		BMP-1.1: BMP Session Establishment and Telemetry Test
Openconfig Lemming		BMP-1.1: BMP Session Establishment and Telemetry Test

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		BMP-1.1: BMP Session Establishment and Telemetry Test
Cisco 8808		BMP-1.1: BMP Session Establishment and Telemetry Test
Juniper PTX10008		BMP-1.1: BMP Session Establishment and Telemetry Test
Nokia 7250 IXR-10e		BMP-1.1: BMP Session Establishment and Telemetry Test

Help

[gemini-code-assist]

Code Review

This pull request introduces vendor-specific configurations for BMP tests, particularly for Juniper, and refactors the default network instance configuration. The changes are generally good, but I've found a critical bug in the new Juniper BMP configuration logic within internal/cfgplugins/bgp.go. The code incorrectly appends to a string builder without resetting it, which will generate invalid CLI commands and cause test failures. I've also noted a deviation from the repository's style guide for cfgplugins. I've provided detailed comments with suggested fixes for these issues.

[vvlakshmanamurthy]

Close this PR as This is covered in PR#4532 and PR#4533

[cprabha]

@vvlakshmanamurthy This pull request is opened to address juniper specific changes required to run test on juniper devices. pull requests mentioned in your comment does not add deviation for juniper. Please check