Skip to content

bmp-1.1 bmp_base_session_test.go #5202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cprabha wants to merge 2 commits into
base: main
Choose a base branch
from
Open

bmp-1.1 bmp_base_session_test.go #5202

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6876c6
bmp-1.1
gauriwalinjkar91 Mar 7, 2026
af2cf8e
Merge branch 'main' into bmp-1.1
cprabha Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions feature/bgp/bmp/otg_tests/bmp_base_session_test/bmp_base_session_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,6 +651,8 @@ func TestBMPBaseSession(t *testing.T) {
dut := ondatra.DUT(t, "dut")
ate := ondatra.ATE(t, "ate")

fptest.ConfigureDefaultNetworkInstance(t, dut)

t.Log("Start DUT Configuration")
configureDUT(t, dut)
t.Log("Start ATE Configuration")
Expand Down
9 changes: 9 additions & 0 deletions feature/bgp/bmp/otg_tests/bmp_base_session_test/metadata.textproto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,13 @@ platform_exceptions: {
default_network_instance: "default"
bmp_oc_unsupported: true
}
}

platform_exceptions: {
platform: {
vendor: JUNIPER
}
deviations: {
bmp_oc_unsupported: true
}
}
137 changes: 99 additions & 38 deletions internal/cfgplugins/bgp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,49 +911,56 @@ func ConfigureDUTBGP(t *testing.T, dut *ondatra.DUTDevice, batch *gnmi.SetBatch,
af6 := global.GetOrCreateAfiSafi(oc.BgpTypes_AFI_SAFI_TYPE_IPV6_UNICAST)
af6.Enabled = ygot.Bool(true)

if cfg.EnableMaxRoutes {
bgpMaxRouteCfg := new(strings.Builder)
fmt.Fprintf(bgpMaxRouteCfg, "router bgp %d\n", cfg.DutAS)
switch dut.Vendor() {
default:

for _, pg := range cfg.PeerGroups {
fmt.Fprintf(bgpMaxRouteCfg, "neighbor %s maximum-routes 0\n", pg)
}
if cfg.EnableMaxRoutes {
bgpMaxRouteCfg := new(strings.Builder)
fmt.Fprintf(bgpMaxRouteCfg, "router bgp %d\n", cfg.DutAS)

helpers.GnmiCLIConfig(t, dut, bgpMaxRouteCfg.String())
}
for _, pg := range cfg.PeerGroups {
fmt.Fprintf(bgpMaxRouteCfg, "neighbor %s maximum-routes 0\n", pg)
}

// Handle multipath deviation
if cfg.ECMPMaxPath > 0 {
if deviations.MultipathUnsupportedNeighborOrAfisafi(dut) {
t.Log("Executing CLI commands for multipath deviation")
bgpRouteConfig := fmt.Sprintf(`
router bgp %d
address-family ipv4
maximum-paths %[2]d ecmp %[2]d
bgp bestpath as-path multipath-relax
address-family ipv6
maximum-paths %[2]d ecmp %[2]d
bgp bestpath as-path multipath-relax
`, cfg.DutAS, cfg.ECMPMaxPath)
helpers.GnmiCLIConfig(t, dut, bgpRouteConfig)
} else {
// TODO: Once multipath is fully supported via OpenConfig across all platforms,
// remove CLI fallback and rely solely on OC configuration.
v4Multipath := af4.GetOrCreateUseMultiplePaths()
v4Multipath.SetEnabled(true)
v4Multipath.GetOrCreateIbgp().SetMaximumPaths(cfg.ECMPMaxPath)
v4Multipath.GetOrCreateEbgp().SetMaximumPaths(cfg.ECMPMaxPath)

v6Multipath := af6.GetOrCreateUseMultiplePaths()
v6Multipath.SetEnabled(true)
v6Multipath.GetOrCreateIbgp().SetMaximumPaths(cfg.ECMPMaxPath)
v6Multipath.GetOrCreateEbgp().SetMaximumPaths(cfg.ECMPMaxPath)

if !deviations.SkipSettingAllowMultipleAS(dut) {
v4Multipath.GetOrCreateEbgp().SetAllowMultipleAs(true)
v6Multipath.GetOrCreateEbgp().SetAllowMultipleAs(true)
helpers.GnmiCLIConfig(t, dut, bgpMaxRouteCfg.String())
}

// Handle multipath deviation
if cfg.ECMPMaxPath > 0 {
if deviations.MultipathUnsupportedNeighborOrAfisafi(dut) {
t.Log("Executing CLI commands for multipath deviation")
bgpRouteConfig := fmt.Sprintf(`
router bgp %d
address-family ipv4
maximum-paths %[2]d ecmp %[2]d
bgp bestpath as-path multipath-relax
address-family ipv6
maximum-paths %[2]d ecmp %[2]d
bgp bestpath as-path multipath-relax
`, cfg.DutAS, cfg.ECMPMaxPath)
helpers.GnmiCLIConfig(t, dut, bgpRouteConfig)
} else {
// TODO: Once multipath is fully supported via OpenConfig across all platforms,
// remove CLI fallback and rely solely on OC configuration.
v4Multipath := af4.GetOrCreateUseMultiplePaths()
v4Multipath.SetEnabled(true)
v4Multipath.GetOrCreateIbgp().SetMaximumPaths(cfg.ECMPMaxPath)
v4Multipath.GetOrCreateEbgp().SetMaximumPaths(cfg.ECMPMaxPath)

v6Multipath := af6.GetOrCreateUseMultiplePaths()
v6Multipath.SetEnabled(true)
v6Multipath.GetOrCreateIbgp().SetMaximumPaths(cfg.ECMPMaxPath)
v6Multipath.GetOrCreateEbgp().SetMaximumPaths(cfg.ECMPMaxPath)

if !deviations.SkipSettingAllowMultipleAS(dut) {
v4Multipath.GetOrCreateEbgp().SetAllowMultipleAs(true)
v6Multipath.GetOrCreateEbgp().SetAllowMultipleAs(true)
}
}

}
case ondatra.JUNIPER:
// Juniper does not need the above configurations for BMP
}
gnmi.BatchUpdate(batch, dutBgpConfPath.Config(), dutBgpConf)
return dutBgpConf
Expand Down Expand Up @@ -1697,6 +1704,60 @@ func ConfigureBMP(t *testing.T, dut *ondatra.DUTDevice, batch *gnmi.SetBatch, cf
`, cfgParams.DutAS)
helpers.GnmiCLIConfig(t, dut, bmpConfig.String())
}
case ondatra.JUNIPER:
fmt.Fprintf(bmpConfig, `
routing-options {
autonomous-system %d;
bmp {
statistics-timeout 30;
station r-bmp {
connection-mode active;
route-monitoring {
loc-rib;
pre-policy;
post-policy;
rib-out pre-policy post-policy;
}
station-address %s;
station-port %d;
}
}
}`, cfgParams.DutAS, cfgParams.StationAddr, cfgParams.StationPort)
helpers.GnmiCLIConfig(t, dut, bmpConfig.String())

if cfgParams.PrePolicy {
t.Log("Configured BMP station with pre-policy export")
fmt.Fprintf(bmpConfig, `
routing-options {
bmp {
station r-bmp {
route-monitoring {
pre-policy;
rib-out pre-policy;
}
}
}
}
`)
helpers.GnmiCLIConfig(t, dut, bmpConfig.String())
}

if cfgParams.PostPolicy {
t.Log("Configured BMP station with post-policy export")
fmt.Fprintf(bmpConfig, `
routing-options {
bmp {
station r-bmp {
route-monitoring {
post-policy;
rib-out post-policy;
}
}
}
}
`)
helpers.GnmiCLIConfig(t, dut, bmpConfig.String())
}
}
} else {
// TODO: BMP OC support is not yet available, so the code below is commented out and will be enabled once BMP is implemented.
Expand Down
Loading