bmp-2.8

[cprabha]

Hi,

1. Adding vendor specific deviation .
2. Batch set variable is not used since some part of the configs are not yet in use, hence commented it out.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces updates to the BMP (BGP Monitoring Protocol) test suite. It primarily addresses vendor-specific deviations by adding a Juniper platform exception and temporarily disables certain batch configuration applications within the test setup, anticipating future configuration readiness.

Highlights

• Vendor Deviation: Added a vendor-specific platform exception for Juniper, marking BMP OpenConfig as unsupported in the test metadata.
• Configuration Batching: Temporarily commented out batch.Set calls in the BMP test configuration due to incomplete related configurations, preventing errors during execution.

Changelog

• feature/bgp/bmp/otg_tests/bmp_post_policy_test/bmp_post_policy_test.go
  • Configured the default network instance for the DUT using fptest.ConfigureDefaultNetworkInstance.
  • Commented out batch.Set calls for BMP and BMP access list configurations, with inline comments explaining that these are temporary measures until related configurations are ready.
• feature/bgp/bmp/otg_tests/bmp_post_policy_test/metadata.textproto
  • Added a new platform_exceptions block for the JUNIPER vendor, specifying bmp_oc_unsupported: true.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5235 / 8a345a6

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		BMP-2.8: BMP Post Policy Test
Cisco 8000E		BMP-2.8: BMP Post Policy Test
Cisco XRd		BMP-2.8: BMP Post Policy Test
Juniper ncPTX		BMP-2.8: BMP Post Policy Test
Nokia SR Linux		BMP-2.8: BMP Post Policy Test
Openconfig Lemming		BMP-2.8: BMP Post Policy Test

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		BMP-2.8: BMP Post Policy Test
Cisco 8808		BMP-2.8: BMP Post Policy Test
Juniper PTX10008		BMP-2.8: BMP Post Policy Test
Nokia 7250 IXR-10e		BMP-2.8: BMP Post Policy Test

Help

[gemini-code-assist]

Code Review

This pull request adds a vendor-specific deviation for Juniper to disable BMP OC support and makes related changes to the test file. My review identifies a couple of areas for improvement in the test code. Specifically, there is a redundant function call that should be removed. Additionally, there's some confusing logic involving a gnmi.SetBatch that is created but never used, along with misleading comments, which should be refactored for better clarity and maintainability. The changes to metadata.textproto are appropriate.

[gemini-code-assist]

This call to fptest.ConfigureDefaultNetworkInstance is redundant. The configureDUT function, which is called a few lines below (line 683), already configures the default network instance on line 204. Please remove this redundant call to avoid unnecessary configuration steps.