Skip to content

bmp-2.8 #5235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cprabha wants to merge 2 commits into
base: main
Choose a base branch
from
Open

bmp-2.8 #5235

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46b0113
adding deviation
gauriwalinjkar91 Mar 17, 2026
8a345a6
vendor spec changes
gauriwalinjkar91 Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions feature/bgp/bmp/otg_tests/bmp_post_policy_test/bmp_post_policy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,6 +677,8 @@ func TestBMPBaseSession(t *testing.T) {
dut := ondatra.DUT(t, "dut")
ate := ondatra.ATE(t, "ate")

fptest.ConfigureDefaultNetworkInstance(t, dut)

Comment on lines +680 to +681
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This call to fptest.ConfigureDefaultNetworkInstance is redundant. The configureDUT function, which is called a few lines below (line 683), already configures the default network instance on line 204. Please remove this redundant call to avoid unnecessary configuration steps.

t.Log("Start DUT Configuration")
configureDUT(t, dut)
t.Log("Start ATE Configuration")
Expand Down Expand Up @@ -708,10 +710,14 @@ func TestBMPBaseSession(t *testing.T) {
batch := &gnmi.SetBatch{}

cfgplugins.ConfigureBMP(t, dut, batch, bmpConfigParams)
batch.Set(t, dut)
// Some part of code where batch config is currently commented and this will give error.
// Hence commenting batch.Set for now, will uncomment once the code is ready.
//batch.Set(t, dut)

cfgplugins.ConfigureBMPAccessList(t, dut, batch, bmpConfigParams)
batch.Set(t, dut)
// Some part of code where batch config is currently commented and this will give error.
// Hence commenting batch.Set for now, will uncomment once the code is ready.
//batch.Set(t, dut)

type testCase struct {
name string
Expand Down
8 changes: 8 additions & 0 deletions feature/bgp/bmp/otg_tests/bmp_post_policy_test/metadata.textproto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,11 @@ platform_exceptions: {
bmp_oc_unsupported: true
}
}
platform_exceptions: {
platform: {
vendor: JUNIPER
}
deviations: {
bmp_oc_unsupported: true
}
}
Loading