fix: add RemoveExistingImage option to container setup

[youssefyamoutyy]

Ensures clean container state before each test run and prevents image conflicts during repeated test executions

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the container setup logic in the connectivity tests to prevent potential image conflicts. By enabling the removal of existing images before test execution, the environment remains consistent and avoids issues during repeated test runs.

Highlights

• Container Configuration: Added the RemoveExistingImage option to the container setup configuration to ensure a clean state.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5289 / ec74ac4

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		CNTR-2: Container network connectivity tests
Cisco 8000E		CNTR-2: Container network connectivity tests
Cisco XRd		CNTR-2: Container network connectivity tests
Juniper ncPTX		CNTR-2: Container network connectivity tests
Nokia SR Linux		CNTR-2: Container network connectivity tests
Openconfig Lemming		CNTR-2: Container network connectivity tests

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		CNTR-2: Container network connectivity tests
Cisco 8808		CNTR-2: Container network connectivity tests
Juniper PTX10008		CNTR-2: Container network connectivity tests
Nokia 7250 IXR-10e		CNTR-2: Container network connectivity tests

Help

[gemini-code-assist]

Code Review

This pull request updates the container setup in cntr_test.go to ensure a clean state by setting RemoveExistingImage to true. Feedback suggests making this parameter configurable via a flag to improve local development efficiency by avoiding redundant image pushes when the image already exists on the device.

[gemini-code-assist]

Hardcoding RemoveExistingImage: true ensures a clean state but may increase test time by forcing a re-push on every run. Consider making this configurable via a flag (similar to container_tar) to allow for faster local development when the image is already present on the DUT.