Skip to content

fix: add RemoveExistingImage option to container setup #5289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
youssefyamoutyy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add RemoveExistingImage option to container setup #5289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions feature/container/networking/tests/container_connectivity/cntr_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ func setupContainer(t *testing.T, dut *ondatra.DUTDevice) func() {
TarPath: containerTarPath(t),
Network: "host",
PollForRunningState: true,
RemoveExistingImage: true,
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Hardcoding RemoveExistingImage: true ensures a clean state but may increase test time by forcing a re-push on every run. Consider making this configurable via a flag (similar to container_tar) to allow for faster local development when the image is already present on the DUT.

}
_, cleanup := containerztest.Setup(ctx, t, dut, opts)
return cleanup
Expand Down
Loading