Skip to content

feat: add icon in action config #11251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Nil20 merged 11 commits into from
Dec 9, 2025
Merged

feat: add icon in action config #11251

Nil20 merged 11 commits into from
Dec 9, 2025
+87 −42

Conversation

@Nil20
Copy link
Contributor

@Nil20 Nil20 commented Dec 8, 2025 •
edited
Loading

Description

  • Make icons configurable for all actions (configurable actions i.e. VALIDATE, custom actions e.g. CUSTOM)
  • Add action icon of action menu appear on action modal

Country Config PR: opencrvs/opencrvs-countryconfig#1174

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@Nil20 Nil20 added the Skip e2e Helps run lint/unit test only for faster feedback. Remove before merge. label Dec 8, 2025
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@Nil20 Nil20 linked an issue Dec 8, 2025 that may be closed by this pull request
Allow configuration of icon for custom action #11051
Open
@Nil20 Nil20 removed the Skip e2e Helps run lint/unit test only for faster feedback. Remove before merge. label Dec 8, 2025
cibelius
cibelius reviewed Dec 8, 2025
View reviewed changes
packages/commons/src/events/ActionConfig.ts
supportingCopy: TranslationConfig.optional().describe(
'Text displayed on the confirmation'
),
icon: AvailableIcons.describe('Icon representing the action').optional(),
Copy link
Contributor

@cibelius cibelius Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👍

@ocrvs-bot
Copy link
Contributor

ocrvs-bot commented Dec 8, 2025

Your environment is deployed to https://ocrvs-11051.e2e-k8s.opencrvs.dev

@Nil20 Nil20 merged commit 295c3da into develop Dec 9, 2025
117 of 118 checks passed
@Nil20 Nil20 deleted the ocrvs-11051 branch December 9, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cibelius cibelius cibelius approved these changes

@Zangetsu101 Zangetsu101 Zangetsu101 approved these changes

@tahmidrahman-dsi tahmidrahman-dsi Awaiting requested review from tahmidrahman-dsi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow configuration of icon for custom action

6 participants

@Nil20 @ocrvs-bot @cibelius @Zangetsu101 @tahmidrahman-dsi