-
Notifications
You must be signed in to change notification settings - Fork 92
feat: add icon in action config #11251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1a9d0ff
feat: add icon in action config
dda3c71
fix: make icon optional
1061084
chore: use icon for custom action
31dcd6b
chore: use icon for all configurable actions
34a8281
fix: group core and configurable actions for action menu
4ba1f7c
feat: use icon in quick action modal
4849a33
chore: use icon for custom action modal
5c88b8b
fix: amend icon size
2d64198
Merge branch 'develop' into ocrvs-11051
Nil20 4a4878f
simplify default icon condition
Nil20 69ccda6
fix: use reusable func
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,7 @@ import { ActionFormConfig } from './FormConfig' | |
| import { DeduplicationConfig } from './DeduplicationConfig' | ||
| import { ActionFlagConfig } from './Flag' | ||
| import { ActionConditional } from './Conditional' | ||
| import { AvailableIcons } from '../icons' | ||
|
|
||
| export const DeclarationReviewConfig = z | ||
| .object({ | ||
|
|
@@ -41,6 +42,7 @@ export const ActionConfigBase = z.object({ | |
| supportingCopy: TranslationConfig.optional().describe( | ||
| 'Text displayed on the confirmation' | ||
| ), | ||
| icon: AvailableIcons.describe('Icon representing the action').optional(), | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perfect 👍 |
||
| conditionals: z | ||
| .array(ActionConditional) | ||
| .optional() | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.