-
Notifications
You must be signed in to change notification settings - Fork 92
Fixes for alpha print button offline functionality #11307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-v1.9.3
Are you sure you want to change the base?
Conversation
… printing offline before registration has occurred
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
| */ | ||
| export const DECLARATION_ACTION_UPDATE = 'UPDATE' as const | ||
| type DECLARATION_ACTION_UPDATE = typeof DECLARATION_ACTION_UPDATE | ||
| const PRINT_DECLARATION_ACTION = 'DECLARE' as const |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In getCurrentEventState:
Declarations are aggregated for all actions except:
// Action types that are not taken into the aggregate values
const EXCLUDED_ACTIONS = [
ActionType.REQUEST_CORRECTION,
ActionType.PRINT_CERTIFICATE,
ActionType.REJECT_CORRECTION
]
And metadata for the following actions:
const updateActions = ActionTypes.extract([
ActionType.CREATE,
ActionType.NOTIFY,
ActionType.DECLARE,
ActionType.VALIDATE,
ActionType.REGISTER,
ActionType.REJECT,
ActionType.ARCHIVE,
ActionType.PRINT_CERTIFICATE,
ActionType.REQUEST_CORRECTION
])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using existing ActionDocument such as DECLARE also allows to resolve the optimistic action sent by the alpha print button, and helps with parsing location names in the certificates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No changes required in certs.
Can access metadata like this: $lookup $metadata 'updatedAtLocation.province'
and declarations like: $lookup $declaration 'mother.occupation'
Description
Addresses issues with usage of alpha print button in offline mode (printing certificate before declaration has been registered by registrar)
Checklist