Skip to content

Fixes for alpha print button offline functionality #11307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pankaj-pant wants to merge 3 commits into
base: release-v1.9.3
Choose a base branch
from
+15 −7
Open

Fixes for alpha print button offline functionality #11307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a1f84d
OCRVS-11027: allow parsing tmp-id when print button is used in offlin…
pankaj-pant Dec 10, 2025
6affaae
fix incorrect import
pankaj-pant Dec 10, 2025
5c6a8ab
OCRVS-10933: pass declaration data and metadata to certificates while…
pankaj-pant Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions packages/client/src/v2-events/features/events/registered-fields/AlphaPrintButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,16 @@ interface PrintButtonProps {
const addedButtonLabel = { id: 'buttons.print', defaultMessage: 'Print' }

/**
* Indicates that declaration action changed declaration content. Satisfies V1 spec.
* Specialized print declaration action used only on the client side.
*
* DECLARE has been used here so that in offline mode
* getCurrentEventState can be tricked to include both
* metadata and declaration data not really persisted
* on the record’s history
*
*/
export const DECLARATION_ACTION_UPDATE = 'UPDATE' as const
type DECLARATION_ACTION_UPDATE = typeof DECLARATION_ACTION_UPDATE
const PRINT_DECLARATION_ACTION = 'DECLARE' as const
Copy link
Contributor Author

@pankaj-pant pankaj-pant Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In getCurrentEventState:
Declarations are aggregated for all actions except:

// Action types that are not taken into the aggregate values
const EXCLUDED_ACTIONS = [
  ActionType.REQUEST_CORRECTION,
  ActionType.PRINT_CERTIFICATE,
  ActionType.REJECT_CORRECTION
]

And metadata for the following actions:

const updateActions = ActionTypes.extract([
  ActionType.CREATE,
  ActionType.NOTIFY,
  ActionType.DECLARE,
  ActionType.VALIDATE,
  ActionType.REGISTER,
  ActionType.REJECT,
  ActionType.ARCHIVE,
  ActionType.PRINT_CERTIFICATE,
  ActionType.REQUEST_CORRECTION
])

Copy link
Contributor Author

@pankaj-pant pankaj-pant Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using existing ActionDocument such as DECLARE also allows to resolve the optimistic action sent by the alpha print button, and helps with parsing location names in the certificates

Copy link
Contributor Author

@pankaj-pant pankaj-pant Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes required in certs.
Can access metadata like this: $lookup $metadata 'updatedAtLocation.province'
and declarations like: $lookup $declaration 'mother.occupation'

type PRINT_DECLARATION_ACTION = typeof PRINT_DECLARATION_ACTION

export const AlphaPrintButton = {
Input: ({
Expand All @@ -62,7 +68,7 @@ export const AlphaPrintButton = {
const intl = useIntl()
const location = useLocation()
const parts = location.pathname.split('/')
const eventId = UUID.parse(parts[3])
const eventId = parts[3] as UUID
const { getEvent } = useEvents()
const { certificateTemplates, language } = useAppConfig()
const { getUser } = useUsers()
Expand All @@ -89,7 +95,7 @@ export const AlphaPrintButton = {
const actionsWithAnOptimisticPrintAction = [
...actions,
{
type: DECLARATION_ACTION_UPDATE,
type: PRINT_DECLARATION_ACTION,
id: getUUID(),
transactionId: getUUID(),
createdByUserType: 'user',
Expand Down
6 changes: 4 additions & 2 deletions ...view/components/EventHistory/EventHistoryDialog/EventHistoryDialog.annotation.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@ import {
generateTrackingId
} from '@opencrvs/commons/client'
import { getTestValidatorContext } from '../../../../../../../../.storybook/decorators'
import { expandWithClientSpecificActions } from '../../../../../events/actions/correct/useActionForHistory'
import { DECLARATION_ACTION_UPDATE } from '../../../../../events/registered-fields'
import {
expandWithClientSpecificActions,
DECLARATION_ACTION_UPDATE
} from '../../../../../events/actions/correct/useActionForHistory'
import { testDataGenerator } from '../../../../../../../tests/test-data-generators'
import { EventHistoryDialog } from './EventHistoryDialog'

Expand Down
Loading