feat(message-queue): allow confirming and rejecting record externally #7674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
naftis
commented
Sep 26, 2024
it would be the correct REST action for the state changes: chose convention for now
naftis
commented
Sep 26, 2024
naftis
commented
Sep 26, 2024
Contributor
|
Your environment is deployed to https://ocrvs-6208-reject-registration.opencrvs.dev. |
Closed
9 tasks
naftis
force-pushed
the
ocrvs-6208-reject-registration
branch
from
bd84e0e to
c2db318
Compare
naftis
commented
Sep 30, 2024
naftis
commented
Oct 1, 2024
2 tasks
rikukissa
reviewed
Oct 7, 2024
rikukissa
approved these changes
Oct 7, 2024
naftis
force-pushed
the
ocrvs-6208-reject-registration
branch
from
2334c1d to
124ec78
Compare
naftis
force-pushed
the
ocrvs-6208-reject-registration
branch
from
124ec78 to
cac78c3
Compare
naftis
force-pushed
the
ocrvs-6208-reject-registration
branch
from
d6ef435 to
edb08fb
Compare
naftis
commented
Oct 9, 2024
Comment on lines
+52
to
+53
| } else if (isNamedType(fieldType)) { | ||
| fieldStr += `${fieldName} ` |
Member
Author
There was a problem hiding this comment.
@rikukissa this was missing enums, that's why the packages/gateway/src/features/registration/__snapshots__/type-resolvers.test.ts.snap test had to be updated
naftis
commented
Oct 10, 2024
Comment on lines
+596
to
+603
| enum RejectionReason { | ||
| OTHER | ||
| } | ||
|
|
||
| input RejectRegistrationInput { | ||
| reason: RejectionReason! # Rejection type | ||
| comment: String! # Free text comment for audit log | ||
| } |
Member
Author
There was a problem hiding this comment.
Not sure yet what type of rejection types could we start amending here.. Essentially this is the same as markEventAsVoided but with a stricter typing
naftis
commented
Oct 10, 2024
Comment on lines
-25
to
-29
| # TODO | ||
| # https://github.com/prismagraphql/graphql-import/issues/180 | ||
| # https://github.com/prismagraphql/graphql-import/issues/45 | ||
| type Dummy { | ||
| dummy: String! |
Member
Author
There was a problem hiding this comment.
These issues were solved in a version we already have
Member
Author
|
@rikukissa Re-requesting a review; note that client & workflow has broken tests. I can amend the main PR to-do |
…into ocrvs-6208-reject-registration
naftis
force-pushed
the
ocrvs-6208-reject-registration
branch
from
db05c3e to
1d9a688
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Country-config: opencrvs/opencrvs-countryconfig#288
Creates two new GraphQL endpoints:
This will also enable integrations such as MOSIP 'hijacking' the confirm path and only doing it when they are ready.