feat: confirm registration via graphql api #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
naftis
changed the title
naftis
changed the title
rikukissa
reviewed
Oct 2, 2024
rikukissa
approved these changes
Oct 2, 2024
2 tasks
naftis
changed the title
…into ocrvs-6208-reject-registration
This was referenced Nov 6, 2024
makelicious
pushed a commit
that referenced
this pull request
Dec 10, 2024
* feat: confirm registration via graphql api (#288) * refactor: remove all graphql related stuff * chore: remove unused code * feat: allow graphql type hints * feat: allow confirming registration via the new graphql api * refactor: use graphql comment so no package needed * refactor: use graphql comment in the last query as well * refactor: throw if the composition doesn't have an id * fix: throw if the id is not found as the function is _get_ * fix: add required env variables * fix: use identifiers instead of childIdentifiers * fix: remove posting tracking id * revert country data changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirms the registration via a new GraphQL API
confirmRegistration. This change was made due to OpenCRVS architecturally going to the direction of handling communications only via gateway's GraphQL endpoint. This allows core to only internally access workflow's/confirm/registrationendpoint and clarifies the divide between internal and external endpoints.The change also enables 3rd party extensions (such as national id mediators) to call
confirmRegistrationwith the child's identifiers.Important
Depends on opencrvs/opencrvs-core#7925