Skip to content

Conversation

@jamil314
Copy link
Contributor

@jamil314 jamil314 commented Sep 29, 2025

Description

Solves: opencrvs/opencrvs-core#10585

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@github-actions
Copy link
Contributor

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@jamil314
Copy link
Contributor Author

image image image

Comment on lines 381 to 390
{{#ifCond (lookup $declaration 'informant.relation') '===' 'Mother' }}
<tspan x="307" y="518.104">{{$lookup $declaration 'mother.name.fullname'}}</tspan>
{{ else }}
{{#ifCond (lookup $declaration 'informant.relation') '===' 'FATHER'}}
{{#ifCond (lookup $declaration 'informant.relation') '===' 'Father'}}
<tspan x="307" y="518.104">{{$lookup $declaration 'father.name.fullname'}}</tspan>
{{ else }}
<tspan x="307" y="518.104">{{$lookup $declaration 'informant.name.fullname'}}</tspan>
{{/ifCond}}
{{/ifCond}}
<tspan x="307" y="528.104">{{$intl 'v2.constants.informant' (lookup $declaration 'informant.relation')}}{{#ifCond (lookup $declaration 'informant.relation') '===' 'OTHER'}} ({{lookup $declaration 'informant.other.relation'}}) {{/ifCond}}</tspan>
<tspan x="307" y="528.104">{{lookup $declaration 'informant.relation'}}{{#ifCond (lookup $declaration 'informant.relation') '===' 'OTHER'}} ({{lookup $declaration 'informant.other.relation'}}) {{/ifCond}}</tspan>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inspect why value of informant.relation could be 'Mother', 'Father' and 'OTHER' as mentioned here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamil314 jamil314 merged commit d79538f into develop Oct 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants