Skip to content

Conversation

@cibelius
Copy link
Contributor

@cibelius cibelius commented Oct 6, 2025

Description

Clearly describe what has been changed. Include relevant context or background.
Explain how the issue was fixed (if applicable) and the root cause.

Link this pull request to the GitHub issue (and optionally name the branch ocrvs-<issue #>)

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@cibelius cibelius changed the title fix fields not to use _ Change fields not to use _ in id. Oct 7, 2025
@cibelius cibelius marked this pull request as ready for review October 7, 2025 12:25
@cibelius cibelius closed this Oct 8, 2025
@cibelius cibelius deleted the ocrvs-10583 branch October 8, 2025 05:47
@cibelius cibelius restored the ocrvs-10583 branch October 8, 2025 09:46
@cibelius cibelius reopened this Oct 8, 2025
Copy link
Contributor

@makelicious makelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update toolkit. Otherwise it will crash since the refine step is not run on countryconfig

@cibelius cibelius merged commit bbeedd2 into develop Oct 8, 2025
2 checks passed
@cibelius cibelius deleted the ocrvs-10583 branch October 8, 2025 13:38
adskyiproger pushed a commit that referenced this pull request Oct 13, 2025
Merge pull request #1066 from opencrvs/ocrvs-10583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants