Skip to content

Conversation

@makelicious
Copy link
Contributor

@makelicious makelicious commented Oct 20, 2025

Best reviewed with 'Hide whitespace' setting.

When running application in slow network condition (reproducible using 3G), the client-config.js might be loaded twice.
This results to issues like Uncaught SyntaxError: "identifier scheme has already been declared at (client-config.js:1:1").

  • On high level, refreshing the browser window requests new document page. The document page includes script tag to load client-config.js.
  • If the network is slow, the browser might start loading and executing client-config.js again before the previous one is torn down, causing the error.

Note

Currently, we do not run e2e tests as a check on opencrvs-countryconfig-repo PRs. Please ensure your PR doesn't break any e2e tests.

One method for doing this is to open a PR with these changes to opencrvs-farajaland as well, and see if the PR check passes there.

Description

Clearly describe what has been changed. Include relevant context or background.
Explain how the issue was fixed (if applicable) and the root cause.

Link this pull request to the GitHub issue (and optionally name the branch ocrvs-<issue #>)

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@github-actions
Copy link
Contributor

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@makelicious makelicious merged commit bf01b97 into develop Oct 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System crash occurs when Print certificate button is clicked twice for slow connectivity from certificate preview page

3 participants