Skip to content

Conversation

@jamil314
Copy link
Contributor

@jamil314 jamil314 commented Dec 3, 2025

Note

Currently, we do not run e2e tests as a check on opencrvs-countryconfig-repo PRs. Please ensure your PR doesn't break any e2e tests.

One method for doing this is to open a PR with these changes to opencrvs-farajaland as well, and see if the PR check passes there.

Description

Clearly describe what has been changed. Include relevant context or background.
Explain how the issue was fixed (if applicable) and the root cause.

Link this pull request to the GitHub issue (and optionally name the branch ocrvs-<issue #>)

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@jamil314
Copy link
Contributor Author

jamil314 commented Dec 3, 2025

image

@jamil314
Copy link
Contributor Author

jamil314 commented Dec 3, 2025

e2e run

Copy link
Contributor

@Zangetsu101 Zangetsu101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change the font to "Noto Sans" too like in the v1.8 PR, as that was requested by @jpye-finch

@jamil314 jamil314 requested a review from Zangetsu101 December 4, 2025 10:09
@Zangetsu101 Zangetsu101 merged commit c3dc99f into release-v1.9.2 Dec 5, 2025
3 checks passed
@Zangetsu101 Zangetsu101 deleted the ocrvs-11147 branch December 5, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide birth certificate header and footer on export to pdf

3 participants