Skip to content

Conversation

@AshwinMN24
Copy link
Contributor

@AshwinMN24 AshwinMN24 commented Sep 19, 2024

We had first cleaned the docker images from the development env servers before deploying. by using below commands.
docker stack ls
NAME SERVICES
opencrvs 34
docker stack rm opencrvs
docker system prine -af

then had triggered the github action with the code changes from https://github.com/opencrvs/opencrvs-farajaland/actions/runs/10938830700/job/30369325656 and then repeated the cleanup process and triggered with the old code changes. https://github.com/opencrvs/opencrvs-farajaland/actions/runs/10937970094

As per the pipeline triggered it had taken less time.

@rikukissa rikukissa requested a review from n1koo September 19, 2024 12:25
@n1koo
Copy link
Contributor

n1koo commented Sep 20, 2024

Looks good but how was this tested? Can you also describe the intent in few lines on the description?

Longer term we should also have error control here - eg if pull failed we shouldnt move forward. Right now it will just hammer through, but this change doesn't really make it any worse just maintains that

done &
done

echo "Images are getting downloaded"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this disappear in the log output of the pull(s)? Eg are they outputting earlier and parallel so this gets lost in their log output...?

If so we can drop this

Copy link
Contributor Author

@AshwinMN24 AshwinMN24 Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I could see it the logs as i have rephrased the sentence "Images download is in process" to "Images are getting downloaded" for better as per the if you check https://github.com/opencrvs/opencrvs-farajaland/actions/runs/10938830700/job/30369325656 (line-194) and in Line- 2190 i have again put check-mark "Images are successfully downloaded" to confirm the images are downloaded and the wait has happened.

@rikukissa rikukissa merged commit c0ec52d into develop Oct 31, 2024
2 checks passed
bvenceslas pushed a commit that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants