Skip to content

#7224 Pull images parallel during deployment #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rikukissa merged 4 commits into from
Oct 31, 2024
Merged

#7224 Pull images parallel during deployment #278

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a920e47
#7224 Pull images parallel during deployment
AshwinMN24 Sep 19, 2024
5729276
Apply suggestions from code review
rikukissa Oct 31, 2024
3556531
Apply suggestions from code review
rikukissa Oct 31, 2024
d432e7b
Merge branch 'develop' into ashwin-work
rikukissa Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
### Improvements

- Auth token, ip address, remote address, mobile number, email redacted/masked from server log
- Improved deployment time by images download faster.

### Infrastructure breaking changes

Expand Down
6 changes: 4 additions & 2 deletions infrastructure/deployment/deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,9 +289,11 @@ docker_stack_deploy() {
do
echo "Server failed to download $tag. Retrying..."
sleep 5
done
done &
done

echo "Images are getting downloaded"
Copy link
Contributor

@n1koo n1koo Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this disappear in the log output of the pull(s)? Eg are they outputting earlier and parallel so this gets lost in their log output...?

If so we can drop this

Copy link
Contributor Author

@AshwinMN24 AshwinMN24 Sep 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I could see it the logs as i have rephrased the sentence "Images download is in process" to "Images are getting downloaded" for better as per the if you check https://github.com/opencrvs/opencrvs-farajaland/actions/runs/10938830700/job/30369325656 (line-194) and in Line- 2190 i have again put check-mark "Images are successfully downloaded" to confirm the images are downloaded and the wait has happened.

wait
echo "Images are successfully downloaded"
echo "Updating docker swarm stack with new compose files"

configured_ssh 'cd /opt/opencrvs && \
Expand Down