Skip to content

RHOAIENG-51571: match with ray cuda params in attempt to trigger build#673

Open
pawelpaszki wants to merge 1 commit intoopendatahub-io:mainfrom
pawelpaszki:RHOAIENG-51571-match-with-ray-cuda-params
Open

RHOAIENG-51571: match with ray cuda params in attempt to trigger build#673
pawelpaszki wants to merge 1 commit intoopendatahub-io:mainfrom
pawelpaszki:RHOAIENG-51571-match-with-ray-cuda-params

Conversation

@pawelpaszki
Copy link
Copy Markdown
Contributor

@pawelpaszki pawelpaszki commented Mar 11, 2026

Description

RHOAIENG-51571: match with ray cuda params in attempt to trigger build

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated build image indexing default configuration
    • Enhanced build validation timeouts
    • Updated build tooling to latest versions

@openshift-ci openshift-ci Bot requested review from ChughShilpa and sutaakar March 11, 2026 07:58
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 11, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kryanbeane for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 11, 2026

📝 Walkthrough

Walkthrough

Configuration changes to a Tekton CI/CD pipeline file for Ray 2.53.0. Three modifications: toggling build-image-index parameter default from false to true, adding a 2-hour timeout constraint to the ecosystem-cert-preflight-checks task, and updating the preflight-checks container image from version 0.1 to 0.2 with a new SHA256 digest.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Actionable items for review:

  • Verify the ecosystem-cert-preflight-checks image SHA256 digest (0.2) against a trusted registry to confirm authenticity and absence of supply chain compromise
  • Confirm the build-image-index default change from false to true aligns with intended build pipeline behavior and does not enable unintended image indexing/pushing in downstream tasks
  • Validate the 2-hour timeout is sufficient for ecosystem-cert-preflight-checks under expected workload conditions; assess if this could mask hanging tasks
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title references a specific Jira ticket and describes matching Ray CUDA parameters to trigger a build, which aligns with the actual changes (updating build-image-index and ecosystem-cert-preflight-checks configuration).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.tekton/ray-2.53.0-py312-rocm64-push.yaml:
- Around line 118-121: The parameter "build-image-index" default was changed to
"true" causing all future ROCm pushes to publish an OCI image index; revert the
default for the build-image-index parameter back to "false" so the pipeline does
not publish a manifest index by default (only override it when intentionally
triggering a run), i.e., update the default value for the "build-image-index"
parameter in this YAML to match sibling ROCm pipelines that use "false".

ℹ️ Review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 1141b16a-8959-40de-a68d-a905273eab62

📥 Commits

Reviewing files that changed from the base of the PR and between 802c43e and 1ed2474.

📒 Files selected for processing (1)
  • .tekton/ray-2.53.0-py312-rocm64-push.yaml

Comment on lines +118 to 121
- default: "true"
description: Add built image into an OCI image index
name: build-image-index
type: string
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Don't persist an artifact-policy change just to force a run.

This flips build-image-index to "true" for every future push of this ROCm lane. The PR objective describes the change as an attempt to trigger a build, and sibling ROCm pipelines still default this to "false" (.tekton/ray-2.52.1-py311-rocm61-push.yaml:117-122). Revert the default unless this pipeline is intentionally meant to publish a manifest index by default now.

Suggested fix
-    - default: "true"
+    - default: "false"
       description: Add built image into an OCI image index
       name: build-image-index
       type: string
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- default: "true"
description: Add built image into an OCI image index
name: build-image-index
type: string
- default: "false"
description: Add built image into an OCI image index
name: build-image-index
type: string
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.tekton/ray-2.53.0-py312-rocm64-push.yaml around lines 118 - 121, The
parameter "build-image-index" default was changed to "true" causing all future
ROCm pushes to publish an OCI image index; revert the default for the
build-image-index parameter back to "false" so the pipeline does not publish a
manifest index by default (only override it when intentionally triggering a
run), i.e., update the default value for the "build-image-index" parameter in
this YAML to match sibling ROCm pipelines that use "false".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant