RHOAIENG-51571: match with ray cuda params in attempt to trigger build#673
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughConfiguration changes to a Tekton CI/CD pipeline file for Ray 2.53.0. Three modifications: toggling Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Actionable items for review:
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.tekton/ray-2.53.0-py312-rocm64-push.yaml:
- Around line 118-121: The parameter "build-image-index" default was changed to
"true" causing all future ROCm pushes to publish an OCI image index; revert the
default for the build-image-index parameter back to "false" so the pipeline does
not publish a manifest index by default (only override it when intentionally
triggering a run), i.e., update the default value for the "build-image-index"
parameter in this YAML to match sibling ROCm pipelines that use "false".
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 1141b16a-8959-40de-a68d-a905273eab62
📒 Files selected for processing (1)
.tekton/ray-2.53.0-py312-rocm64-push.yaml
| - default: "true" | ||
| description: Add built image into an OCI image index | ||
| name: build-image-index | ||
| type: string |
There was a problem hiding this comment.
Don't persist an artifact-policy change just to force a run.
This flips build-image-index to "true" for every future push of this ROCm lane. The PR objective describes the change as an attempt to trigger a build, and sibling ROCm pipelines still default this to "false" (.tekton/ray-2.52.1-py311-rocm61-push.yaml:117-122). Revert the default unless this pipeline is intentionally meant to publish a manifest index by default now.
Suggested fix
- - default: "true"
+ - default: "false"
description: Add built image into an OCI image index
name: build-image-index
type: string📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - default: "true" | |
| description: Add built image into an OCI image index | |
| name: build-image-index | |
| type: string | |
| - default: "false" | |
| description: Add built image into an OCI image index | |
| name: build-image-index | |
| type: string |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.tekton/ray-2.53.0-py312-rocm64-push.yaml around lines 118 - 121, The
parameter "build-image-index" default was changed to "true" causing all future
ROCm pushes to publish an OCI image index; revert the default for the
build-image-index parameter back to "false" so the pipeline does not publish a
manifest index by default (only override it when intentionally triggering a
run), i.e., update the default value for the "build-image-index" parameter in
this YAML to match sibling ROCm pipelines that use "false".
Description
RHOAIENG-51571: match with ray cuda params in attempt to trigger build
How Has This Been Tested?
Merge criteria:
Summary by CodeRabbit
Release Notes