Skip to content

RHOAIENG-51571: match with ray cuda params in attempt to trigger build #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pawelpaszki wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RHOAIENG-51571: match with ray cuda params in attempt to trigger build #673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .tekton/ray-2.53.0-py312-rocm64-push.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ spec:
description: Build a source image.
name: build-source-image
type: string
- default: "false"
- default: "true"
description: Add built image into an OCI image index
name: build-image-index
type: string
Comment on lines +118 to 121
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Don't persist an artifact-policy change just to force a run.

This flips build-image-index to "true" for every future push of this ROCm lane. The PR objective describes the change as an attempt to trigger a build, and sibling ROCm pipelines still default this to "false" (.tekton/ray-2.52.1-py311-rocm61-push.yaml:117-122). Revert the default unless this pipeline is intentionally meant to publish a manifest index by default now.

Suggested fix 
-    - default: "true"
+    - default: "false"
       description: Add built image into an OCI image index
       name: build-image-index
       type: string
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- default: "true"
description: Add built image into an OCI image index
name: build-image-index
type: string
- default: "false"
description: Add built image into an OCI image index
name: build-image-index
type: string
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.tekton/ray-2.53.0-py312-rocm64-push.yaml around lines 118 - 121, The
parameter "build-image-index" default was changed to "true" causing all future
ROCm pushes to publish an OCI image index; revert the default for the
build-image-index parameter back to "false" so the pipeline does not publish a
manifest index by default (only override it when intentionally triggering a
run), i.e., update the default value for the "build-image-index" parameter in
this YAML to match sibling ROCm pipelines that use "false".

Expand Down Expand Up @@ -356,6 +356,7 @@ spec:
values:
- "false"
- name: ecosystem-cert-preflight-checks
timeout: 2h
params:
- name: image-url
value: $(tasks.build-image-index.results.IMAGE_URL)
Expand All @@ -366,7 +367,7 @@ spec:
- name: name
value: ecosystem-cert-preflight-checks
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-ecosystem-cert-preflight-checks:0.1@sha256:5131cce0f93d0b728c7bcc0d6cee4c61d4c9f67c6d619c627e41e3c9775b497d
value: quay.io/konflux-ci/tekton-catalog/task-ecosystem-cert-preflight-checks:0.2@sha256:51ee3ca7b8142f39a2861ed0f94f67e02c538e3b7e57de56ed301fbb9774aa12
- name: kind
value: task
resolver: bundles
Expand Down