Skip to content

Revert "Add bash completions and oc completions and nano to the image"#32

Merged
lburgazzoli merged 4 commits intomainfrom
revert-25-bash-completions
Feb 24, 2026
Merged

Revert "Add bash completions and oc completions and nano to the image"#32
lburgazzoli merged 4 commits intomainfrom
revert-25-bash-completions

Conversation

@lburgazzoli
Copy link
Copy Markdown
Member

@lburgazzoli lburgazzoli commented Feb 24, 2026

Reverts #25

Summary by CodeRabbit

  • Chores
    • Optimized runtime container image by removing unnecessary development utilities and configurations, resulting in a streamlined and more efficient deployment footprint.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 1a1c246 and 92346d8.

📒 Files selected for processing (1)
  • Dockerfile

📝 Walkthrough

Walkthrough

The Dockerfile was simplified by removing the installation of nano and bash-completion utilities, along with a dedicated build step for configuring oc bash completions and related comments.

Changes

Cohort / File(s) Summary
Dockerfile Simplification
Dockerfile
Removed nano and bash-completion package installations from the runtime image base utilities step; removed dedicated RUN step for oc bash completion configuration; removed associated comment blocks.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: reverting a previous commit that added bash completions, oc completions, and nano to the Docker image.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-25-bash-completions

Comment @coderabbitai help to get the list of available commands and usage tips.

@lburgazzoli
Copy link
Copy Markdown
Member Author

@sheltoncyril reverting it as it fails when building the container images

@lburgazzoli lburgazzoli merged commit 1f0e1ea into main Feb 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants