Skip to content

Revert "Add bash completions and oc completions and nano to the image" #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lburgazzoli merged 4 commits into from
Feb 24, 2026
Merged

Revert "Add bash completions and oc completions and nano to the image" #32

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e618779
Revert "fix: naming scheme fix"
lburgazzoli Feb 24, 2026
1858472
Revert "docs: add comments"
lburgazzoli Feb 24, 2026
82bb7ea
Revert "fix: address coderabbit concerns"
lburgazzoli Feb 24, 2026
92346d8
Revert "feat: add bash completions and oc completions"
lburgazzoli Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,12 @@ ARG TARGETARCH
# Users can override this with -e KUBECONFIG=<path> when running the container
ENV KUBECONFIG=/kubeconfig

# Install base utilities (jq, wget, python3, python3-pip, nano, bash-completion)
# Install base utilities (jq, wget, python3, python3-pip)
RUN yum install -y \
jq \
wget \
python3 \
python3-pip \
nano \
bash-completion \
&& yum clean all

# Python deps for ray_cluster_migration.py (kubernetes, PyYAML)
Expand Down Expand Up @@ -121,9 +119,6 @@ ENV PATH="/opt/rhai-cli/bin:${PATH}"
# Copy upgrade helpers from builder
COPY --from=builder /opt/rhai-upgrade-helpers /opt/rhai-upgrade-helpers

# Add oc bash completions to enhance user experience when using oc inside the container
RUN oc completion bash > /etc/bash_completion.d/oc

# Set entrypoint to rhai-cli binary
# Users can override with --entrypoint /bin/bash for interactive debugging
ENTRYPOINT ["/opt/rhai-cli/bin/rhai-cli"]