Fix with new kserve version moving from RawDeployment namee to standard#1283
Fix with new kserve version moving from RawDeployment namee to standard#1283mwaykole merged 3 commits intoopendatahub-io:mainfrom
Conversation
Signed-off-by: Milind waykole <mwaykole@redhat.com>
|
The following are automatically added/executed:
Available user actions:
Supported labels{'/wip', '/build-push-pr-image', '/hold', '/verified', '/lgtm', '/cherry-pick'} |
for more information, see https://pre-commit.ci
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughRefactored deployment mode checks across KServe utilities to use a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Actionable issues:
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Status of building tag latest: success. |
…rd (opendatahub-io#1283) * Fix with new kserve version moving from RawDeployment namee to standard Signed-off-by: Milind waykole <mwaykole@redhat.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Milind waykole <mwaykole@redhat.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Karishma Punwatkar <kpunwatk@redhat.com>
Pull Request
Summary
Newer versions of KServe renamed the RawDeployment deployment mode to Standard. The KServe controller on the cluster now converts the serving.kserve.io/deploymentMode annotation from RawDeployment to Standard, causing test failures with ValueError: Unknown deployment mode Standard.
This PR adds Standard as a recognized deployment mode and treats it identically to RawDeployment across the test framework.
Related Issues
How it has been tested
Additional Requirements
Summary by CodeRabbit
New Features
Refactor