fix: update expected notebook ImageStream count from 11 to 14#1306
Closed
fix: update expected notebook ImageStream count from 11 to 14#1306
Conversation
|
The following are automatically added/executed:
Available user actions:
Supported labels{'/lgtm', '/cherry-pick', '/build-push-pr-image', '/wip', '/hold', '/verified'} |
Three new training-hub-universal ImageStreams (cpu, cuda, rocm) from the trainer component now carry the opendatahub.io/notebook-image=true label. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Jiri Daněk <jdanek@redhat.com>
1c31c05 to
e29b194
Compare
Contributor
📝 WalkthroughWalkthroughTwo test files updated to reflect changed ImageStream count expectations: notebook image ImageStreams increased from 11 to 14, while runtime image expectations remain at 7. No logic or control flow modifications. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Member
|
I would rather prefer the #1304. |
Member
|
Closing in favor of #1304 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
training-hub-universal-*ImageStreams (cpu,cuda,rocm) from the trainer component now carry theopendatahub.io/notebook-image=truelabelContext
Slack thread:
Test plan
test_workbench_imagestreams_health[notebook_imagestreams]against a cluster with the new ImageStreams🤖 Generated with Claude Code
Summary by CodeRabbit