Skip to content

fix: update expected notebook ImageStream count from 11 to 14#1306

Closed
jiridanek wants to merge 1 commit intomainfrom
fix-notebook-imagestream-count
Closed

fix: update expected notebook ImageStream count from 11 to 14#1306
jiridanek wants to merge 1 commit intomainfrom
fix-notebook-imagestream-count

Conversation

@jiridanek
Copy link
Copy Markdown
Member

@jiridanek jiridanek commented Mar 26, 2026

Summary

  • Three new training-hub-universal-* ImageStreams (cpu, cuda, rocm) from the trainer component now carry the opendatahub.io/notebook-image=true label
  • Updated expected notebook ImageStream count from 11 to 14 in test and README

Context

Slack thread:

Test plan

  • Run test_workbench_imagestreams_health[notebook_imagestreams] against a cluster with the new ImageStreams

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests
    • Updated ImageStream validation test expectations for notebook-related images, adjusting expected count from 11 to 14.

@github-actions
Copy link
Copy Markdown

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee
  • Build image based on the PR

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
    and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
  • To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
    pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.
Supported labels

{'/lgtm', '/cherry-pick', '/build-push-pr-image', '/wip', '/hold', '/verified'}

Three new training-hub-universal ImageStreams (cpu, cuda, rocm) from
the trainer component now carry the opendatahub.io/notebook-image=true
label.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
@jiridanek jiridanek force-pushed the fix-notebook-imagestream-count branch from 1c31c05 to e29b194 Compare March 26, 2026 10:28
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 26, 2026

📝 Walkthrough

Walkthrough

Two test files updated to reflect changed ImageStream count expectations: notebook image ImageStreams increased from 11 to 14, while runtime image expectations remain at 7. No logic or control flow modifications.

Changes

Cohort / File(s) Summary
Test Expectation Updates
tests/workbenches/README.md, tests/workbenches/test_imagestream_health.py
Updated expected ImageStream count for notebook-related images from 11 to 14; tag digest and ImportSuccess condition checks unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: updating the expected notebook ImageStream count from 11 to 14, which is the primary modification across both files.
Description check ✅ Passed The pull request description provides a clear summary, context, and test plan with direct evidence of testing the specific changes made.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-notebook-imagestream-count

Comment @coderabbitai help to get the list of available commands and usage tips.

@jstourac
Copy link
Copy Markdown
Member

I would rather prefer the #1304.

@jstourac
Copy link
Copy Markdown
Member

Closing in favor of #1304

@jstourac jstourac closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants