Skip to content

Fix timing issue for the test#1334

Merged
dbasunag merged 1 commit intoopendatahub-io:mainfrom
mwaykole:fix-faileure-smoke12
Apr 1, 2026
Merged

Fix timing issue for the test#1334
dbasunag merged 1 commit intoopendatahub-io:mainfrom
mwaykole:fix-faileure-smoke12

Conversation

@mwaykole
Copy link
Copy Markdown
Member

@mwaykole mwaykole commented Apr 1, 2026

Pull Request

Summary

Related Issues

  • Fixes:
  • JIRA:

Please review and indicate how it has been tested

  • Locally
  • Jenkins

Additional Requirements

  • If this PR introduces a new test image, did you create a PR to mirror it in disconnected environment?
  • If this PR introduces new marker(s)/adds a new component, was relevant ticket created to update relevant Jenkins job?

Summary by CodeRabbit

  • Tests
    • Improved test infrastructure reliability for model serving by adding synchronization checks for inference deployment readiness, ensuring more stable test execution.

Signed-off-by: Milind waykole <mwaykole@redhat.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee
  • Build image based on the PR

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
    and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
  • To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
    pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.
Supported labels

{'/build-push-pr-image', '/lgtm', '/hold', '/verified', '/wip', '/cherry-pick'}

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 1606547b-5ccd-45f1-8747-ab706adc7b06

📥 Commits

Reviewing files that changed from the base of the PR and between 8968196 and bad3dc7.

📒 Files selected for processing (1)
  • tests/model_serving/model_server/kserve/authentication/conftest.py

📝 Walkthrough

Walkthrough

Test fixture modification adds explicit waits for inference deployment replica readiness following ISVC completion. The synchronization calls occur both before yielding within the ResourceEditor context and after context exit.

Changes

Cohort / File(s) Summary
Test Fixture Synchronization
tests/model_serving/model_server/kserve/authentication/conftest.py
Added import and two wait_for_inference_deployment_replicas() calls to the patched_remove_raw_authentication_isvc fixture—one pre-yield within ResourceEditor context, one post-context exit. Ensures replica reconciliation completes between fixture setup and test execution.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is completely empty—all sections remain as template placeholders with no actual information filled in about changes, testing, or related issues. Fill in the Summary section describing the timing issue and the wait_for_inference_deployment_replicas fix, specify related issues/JIRA tickets, and indicate test verification method (Locally/Jenkins).
Title check ❓ Inconclusive The title 'Fix timing issue for the test' is vague and generic, lacking specificity about which timing issue or test is being addressed. Replace with a more specific title that identifies the component and the specific timing problem, e.g., 'Add wait_for_inference_deployment_replicas synchronization in kserve conftest fixture'.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@dbasunag dbasunag merged commit 65bbddb into opendatahub-io:main Apr 1, 2026
11 checks passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Status of building tag latest: success.
Status of pushing tag latest to image registry: success.

@threcc
Copy link
Copy Markdown
Contributor

threcc commented Apr 2, 2026

/cherry-pick 3.4ea2

@rhods-ci-bot
Copy link
Copy Markdown
Contributor

Error cherry-picking.

Auto-merging tests/model_serving/model_server/kserve/authentication/conftest.py
CONFLICT (content): Merge conflict in tests/model_serving/model_server/kserve/authentication/conftest.py
error: could not apply 65bbddb... Fix timing issue for the test (#1334)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

@rhods-ci-bot
Copy link
Copy Markdown
Contributor

‼️ cherry pick action failed.
See: https://github.com/opendatahub-io/opendatahub-tests/actions/runs/23904805453

threcc pushed a commit to threcc/opendatahub-tests that referenced this pull request Apr 2, 2026
Signed-off-by: Milind waykole <mwaykole@redhat.com>
dbasunag added a commit that referenced this pull request Apr 3, 2026
* Fix timing issue for the test (#1334)

Signed-off-by: Milind waykole <mwaykole@redhat.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* precommit

Signed-off-by: threcc <trecchiu@redhat.com>

* chore: add skip-unused-code for is_jira_open() call

Signed-off-by: Debarati Basu-Nag <dbasunag@redhat.com>

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Signed-off-by: Milind waykole <mwaykole@redhat.com>
Signed-off-by: threcc <trecchiu@redhat.com>
Co-authored-by: Milind Waykole <mwaykole@redhat.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Debarati Basu-Nag <dbasunag@redhat.com>
Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants