Skip to content

fix(tests): backport operator_health marker split from main to 2.25#1335

Merged
dbasunag merged 2 commits intoopendatahub-io:2.25from
crackcodecamp:backport-operator-health-marker-2.25
Apr 1, 2026
Merged

fix(tests): backport operator_health marker split from main to 2.25#1335
dbasunag merged 2 commits intoopendatahub-io:2.25from
crackcodecamp:backport-operator-health-marker-2.25

Conversation

@crackcodecamp
Copy link
Copy Markdown

Split operator health tests from test_cluster_health.py into test_operator_health.py with the operator_health pytest marker. This aligns the 2.25 branch with main, fixing the Jenkins pipeline failure where validateHealth(type: "operator") uses -m operator_health but no tests had that marker, causing all tests to be deselected (exit code 5) and the pipeline to fail.

Summary

  • Split operator health tests from test_cluster_health.py into test_operator_health.py with
    @pytest.mark.operator_health marker
  • Registered operator_health marker in pytest.ini
  • Aligns the 2.25 branch with main, matching the refactoring done in the upstream tests

Problem

The Jenkins pipeline (ods/jenkins shared library) calls validateHealth(type: "operator") which runs pytest with
-m operator_health. On the 2.25 branch, all tests only had the cluster_health marker, causing all 5 tests to be
deselected (exit code 5) and the pipeline to fail with:

PIPELINE STOPPED: RHOAI Operator Health Check failed! The operator deployment is not healthy

The cluster is actually healthy — this is a marker mismatch, not a real health issue.

Changes

File Change
pytest.ini Added operator_health marker registration
tests/cluster_health/test_cluster_health.py Kept only test_cluster_node_healthy with cluster_health marker
tests/cluster_health/test_operator_health.py New file with 3 operator tests using operator_health marker

@crackcodecamp crackcodecamp requested a review from a team as a code owner April 1, 2026 12:26
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4944e3a8-4707-4292-896d-8c371f594189

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee
  • Build image based on the PR

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
    and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
  • To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
    pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.
Supported labels

{'/build-push-pr-image', '/verified', '/hold', '/wip', '/lgtm', '/cherry-pick'}

Split operator health tests from test_cluster_health.py into
test_operator_health.py with the operator_health pytest marker.
This aligns the 2.25 branch with main, fixing the Jenkins pipeline
failure where validateHealth(type: "operator") uses -m operator_health
but no tests had that marker, causing all tests to be deselected
(exit code 5) and the pipeline to fail.

Signed-off-by: Akshay Ghodake <aghodake@redhat.com>
@crackcodecamp crackcodecamp force-pushed the backport-operator-health-marker-2.25 branch from 3255289 to a1dd0b0 Compare April 1, 2026 12:28
@dbasunag dbasunag merged commit f6bf799 into opendatahub-io:2.25 Apr 1, 2026
10 checks passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Status of building tag 2.25: success.
Status of pushing tag 2.25 to image registry: success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants