fix(tests): backport operator_health marker split from main to 2.25#1335
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following are automatically added/executed:
Available user actions:
Supported labels{'/build-push-pr-image', '/verified', '/hold', '/wip', '/lgtm', '/cherry-pick'} |
Split operator health tests from test_cluster_health.py into test_operator_health.py with the operator_health pytest marker. This aligns the 2.25 branch with main, fixing the Jenkins pipeline failure where validateHealth(type: "operator") uses -m operator_health but no tests had that marker, causing all tests to be deselected (exit code 5) and the pipeline to fail. Signed-off-by: Akshay Ghodake <aghodake@redhat.com>
3255289 to
a1dd0b0
Compare
|
Status of building tag 2.25: success. |
Split operator health tests from test_cluster_health.py into test_operator_health.py with the operator_health pytest marker. This aligns the 2.25 branch with main, fixing the Jenkins pipeline failure where validateHealth(type: "operator") uses -m operator_health but no tests had that marker, causing all tests to be deselected (exit code 5) and the pipeline to fail.
Summary
test_cluster_health.pyintotest_operator_health.pywith@pytest.mark.operator_healthmarkeroperator_healthmarker inpytest.inimain, matching the refactoring done in the upstream testsProblem
The Jenkins pipeline (
ods/jenkinsshared library) callsvalidateHealth(type: "operator")which runs pytest with-m operator_health. On the 2.25 branch, all tests only had thecluster_healthmarker, causing all 5 tests to bedeselected (exit code 5) and the pipeline to fail with:
The cluster is actually healthy — this is a marker mismatch, not a real health issue.
Changes
pytest.inioperator_healthmarker registrationtests/cluster_health/test_cluster_health.pytest_cluster_node_healthywithcluster_healthmarkertests/cluster_health/test_operator_health.pyoperator_healthmarker