fix(manifests): fix prometheus monitoring config

[robert-bell]

What this PR does / why we need it:

Fixes the port and tls config for the prometheus monitoring config. Kubebuilder by default serves metrics on 8443 with tls enabled, but for some reason we had the metrics port set to 8080.

I've tested the config in a kind cluster.

This is part of https://issues.redhat.com/browse/RHOAIENG-37877.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

• Docs included if any changes are user facing

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions:
   | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context.
   Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[robert-bell]

question: @sutaakar is it acceptable to skip cert checks for prod? I had a look at how other components are doing it and I saw this pattern in a few places (e.g. feast-operator).

Oddly, when I tested it locally without this setting prometheus didn't object to the certs being untrusted. Does kubebuilder do anything clever to mean the certs are trusted? It might just have been some misconfig in my local prometheus setup.

[sutaakar]

question: @sutaakar is it acceptable to skip

not sure, I guess we can follow config of other components

[robert-bell]

@sutaakar is there anything else that needs doing to make sure the prometheus operator picks up the podmonitor? Are there any labels that need adding? Do we need to do any extra testing of the set up with the odh operator or is it OK to let those builds fail (if there is a problem)?

I saw you've already added the prometheus rule in opendatahub-io/opendatahub-operator#2854.

[sutaakar]

I guess it will be best to check it once everything is merged, hopefully it shouldn't break anything

[sutaakar]

/lgtm