Skip to content

fix(manifests): fix prometheus monitoring config #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robert-bell merged 1 commit into from
Nov 21, 2025
+4 −1
Merged

fix(manifests): fix prometheus monitoring config #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/rhoai/manager_metrics_patch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ spec:
containers:
- name: manager
ports:
- containerPort: 8080
- containerPort: 8443
name: metrics
3 changes: 3 additions & 0 deletions manifests/rhoai/monitor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,6 @@ spec:
app.kubernetes.io/component: controller
podMetricsEndpoints:
- port: metrics
scheme: https
tlsConfig:
insecureSkipVerify: true
Copy link
Copy Markdown
Collaborator Author

@robert-bell robert-bell Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: @sutaakar is it acceptable to skip cert checks for prod? I had a look at how other components are doing it and I saw this pattern in a few places (e.g. feast-operator).

Oddly, when I tested it locally without this setting prometheus didn't object to the certs being untrusted. Does kubebuilder do anything clever to mean the certs are trusted? It might just have been some misconfig in my local prometheus setup.

Copy link
Copy Markdown
Collaborator

@sutaakar sutaakar Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: @sutaakar is it acceptable to skip

not sure, I guess we can follow config of other components

Loading